make openmp and lapack link libs targets private #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dustinswales can you please test out this branch when you get a chance re: the private vs. public openmp issue? I can compile UWM succesfully with it, but I wasn't able to reproduce the problem with the current ip code, so it would be great if you can verify that this will actually fix it (and also not break anything...). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the target_link_libraries properties for lapack and openmp from PUBLIC to PRIVATE.
Also adding 'concurrency:cancel-in-progress:true' to all the CI workflows.
Fixes #276
Fixes #234