Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up unused code and options #95

Closed
DeniseWorthen opened this issue Apr 1, 2021 · 0 comments
Closed

clean up unused code and options #95

DeniseWorthen opened this issue Apr 1, 2021 · 0 comments

Comments

@DeniseWorthen
Copy link
Contributor

DeniseWorthen commented Apr 1, 2021

  • The module_MEDIATOR, module_MEDIATOR_methods and the module_MEDIATOR_SpaceWeather should be removed.

  • Various legacy ifdef settings (eg. ifdef CMEPS, if ESMF_VERSION_MAJOR < 8) as well as non-existent or legacy models (ifdef FRONT_GSM) should be removed.

  • The large block of code for adding entries to the Field Dictionary should be removed and the fd_nems.yaml used instead.

  • The bail-out error checking lines should be simplified by adding a similar ChkErr function present in the MOM6 NUOPC cap and CMEPS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant