Combined PR: NEMS Driver cleanup (#533), Wave update (#542), add CPLD&DATM tests on Jet (#545) #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplify some of the CMake and add future flexibility for gnu
This reverts commit cea6fc6.
This reverts commit 7b826d4.
*update NEMS submodule *set mediator as cmeps in nems.configure* *copy yaml field dictionary when runnning ATM,ATMW
*remove nems mediator subroutines *update CMakeLists *remove med_model from MED_attributes
*switch to new NEMS branch cleanup_v2
*hera.intel and hera.gnu both pass *rename branch
|
@binli2337 The hera intel and gnu passed so if you haven't started the replacement baselines on jet yet I think everything should now be correct and you can start. @DeniseWorthen Three tests have completed. |
|
CI test passed for 4f593f9: https://github.com/ufs-community/ufs-weather-model/actions/runs/807177711 |
MinsukJi-NOAA
approved these changes
May 3, 2021
junwang-noaa
approved these changes
May 3, 2021
|
@binli2337 Are we ready to run the auto-RT on Jet? |
|
@DeniseWorthen New baselines are ready on Jet. |
|
All RTs have completed and all passed. This is ready to merge after NEMS is updated and I revert the submodule. |
This was referenced May 4, 2021
pjpegion
pushed a commit
to NOAA-PSL/ufs-weather-model
that referenced
this pull request
Apr 4, 2023
* 20220505 Jesse Meng create branch upp_unify_inline_2d from * 20220610 Jesse Meng update upp url
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
…#533) * Changes required to produce the diag_table file at forecast run time. * Minor syntax changes. * Syntax bug fix and update to header. * Update create_diag_table_file.sh * Update setup.sh * Update setup.sh
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
* add sphinx_rtd_theme to conf.py * pin sphinx_rtd_theme==0.5.1 in req file * pin docutils==0.17 * pin Pygments-2.13.0 * pinned sphinx_rtd_theme==1.1.1 * pin sphinx==5.3.0 * pin importlib-metadata==5.2.0 * pin pillow==9.3.0 * set docutils==0.16 * comment out unwanted pinnings * remove unnecessary changes for formatting fix * add back sphinx_rtd_theme extension in conf.py Co-authored-by: gspetro <gillian.s.petro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Issue(s) addressed
NEMS issue #95
Includes PR #542
Includes PR #545
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Pre-commit testing shows these changes are B4B for both gnu and intel on Hera.
Also tested on Gaea after addition of Wave and Jet PRs and all tests passed.
Dependencies
NEMS PR #98
co-authors:
@JessicaMeixner-NOAA
@binli2337