-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WW3 to latest + fix for WW3 compile on Gaea #542
Closed
JessicaMeixner-NOAA
wants to merge
4
commits into
ufs-community:develop
from
JessicaMeixner-NOAA:updateWWgaeamodule
Closed
Update WW3 to latest + fix for WW3 compile on Gaea #542
JessicaMeixner-NOAA
wants to merge
4
commits into
ufs-community:develop
from
JessicaMeixner-NOAA:updateWWgaeamodule
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the WW3 switch preprocessing routines
@JessicaMeixner-NOAA Please update your branch and I will bring it into to PR #533 |
@DeniseWorthen done - let me know if there's anything else I need to do. |
@JessicaMeixner-NOAA please bring these up to date with respective authoritative repositories
|
Merged
13 tasks
Combined with PR #533 |
DeniseWorthen
added a commit
that referenced
this pull request
May 3, 2021
…&DATM tests on Jet (#545) (#533) * update ufs-weather for removing nems mediator * set mediator as cmeps in nems.configure* * copy yaml field dictionary when runnning ATM,ATMW * update NEMS and CMakeLists, nems.configure * add a gcc module so that gfortran can be found when building the WW3 switch preprocessing routines * Add datm and coupled tests to Jet. Co-authored-by: Jessica.Meixner <Jessica.Meixner@noaa.gov> Co-authored-by: Bin.Li <bin.li@noaa.gov>
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
## DESCRIPTION OF CHANGES: This PR addresses an error that occurs at run time ```ModuleNotFoundError: No module named 'f90nml'```. A similar error may appear in any of the tasks that use a conda environment, and could potentially list `jinja2` instead. The version of lmod on Hera was updated. The behavior of the `system` command has changed and now runs only in a subshell. As an lmod-version-independent fix, the module will no longer activate a conda environment, but will set the conda environment that should be activated through an environment variable, then the script will activate any required conda environment. Note: Users who do not run with Rocoto, but still use these modules, will have an extra step of activating the conda environment manually. ## TESTS CONDUCTED: Built and ran a single WE2E test (grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2) successfully on Hera with these modifications, as well as a WE2E test (DOT_OR_USCORE) on Orion as a sanity check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Description
Updates WW3 to its latest develop branch. This is important as it will incorporate a compile fix used but other WW3 exes for netcdf + hpc-stack to work, which is needed in the global-workflow.
In addition, this PR addresses issue #511 for building S2SW on Gaea. However, it does not turn on this Gaea test in an effort to not change baselines in this PR (allowing it to be easily combined with any other PR). A subsequent PR will include turning on the Gaea tests with waves.
Issue(s) addressed
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
The regression tests were successful on orion.intel before submitting. @DeniseWorthen tested the S2SW compile on Gaea.
Dependencies
none