Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined PR: NEMS Driver cleanup (#533), Wave update (#542), add CPLD&DATM tests on Jet (#545) #533

Merged
Merged
Show file tree
Hide file tree
Changes from 82 commits
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
7a2d7d2
updating WW3 to add gaea, jet and now use '$platform.intel' to
JessicaMeixner-NOAA Feb 8, 2021
09ff847
add WW3 tests on more platforms
JessicaMeixner-NOAA Feb 8, 2021
18f4026
current updates for balancing wave tests
JessicaMeixner-NOAA Feb 12, 2021
6c8a17d
update WW3
JessicaMeixner-NOAA Feb 17, 2021
8d34b58
Merge remote-tracking branch 'UFS/develop' into feature/portww3
JessicaMeixner-NOAA Feb 17, 2021
c448e05
Merge remote-tracking branch 'UFS/develop' into feature/portww3
JessicaMeixner-NOAA Feb 22, 2021
7b826d4
update FV3
DeniseWorthen Mar 27, 2021
cea6fc6
update hera.intel modulefiles for testing
DeniseWorthen Mar 27, 2021
071275b
Revert "update hera.intel modulefiles for testing"
DeniseWorthen Mar 27, 2021
4db2ff2
Revert "update FV3"
DeniseWorthen Mar 27, 2021
5a8d4b6
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Mar 30, 2021
09716fe
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Mar 31, 2021
f20d105
update ufs-weather for removing nems mediator
DeniseWorthen Apr 4, 2021
f041f64
update NEMS and CMakeLists, nems.configure
DeniseWorthen Apr 5, 2021
f778ec2
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Apr 5, 2021
03c3a34
Merge branch 'develop' into feature/nemscleanup
DeniseWorthen Apr 5, 2021
4d6b72b
update NEMS
DeniseWorthen Apr 5, 2021
3de805f
cpld_controlfrac passes RT
DeniseWorthen Apr 5, 2021
3ae6d69
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Apr 9, 2021
d3bf24b
Merge branch 'develop' into feature/nemscleanup
DeniseWorthen Apr 9, 2021
f187e64
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Apr 10, 2021
81c08a0
Merge branch 'develop' into feature/nemscleanup
DeniseWorthen Apr 10, 2021
e736061
update NEMS
DeniseWorthen Apr 10, 2021
94f5e67
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Apr 12, 2021
4100179
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Apr 15, 2021
42d1a64
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Apr 16, 2021
19e2579
Merge branch 'develop' into feature/cleanup
DeniseWorthen Apr 17, 2021
f39c636
update NEMS branch
DeniseWorthen Apr 17, 2021
2332de3
Merge branch 'develop' into feature/nemsdriver_cleanup
DeniseWorthen Apr 17, 2021
8a5575b
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Apr 19, 2021
df5c043
Merge branch 'develop' into feature/nemsdriver_cleanup
DeniseWorthen Apr 19, 2021
44455fc
update nems for printatt false
DeniseWorthen Apr 19, 2021
9a06325
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Apr 20, 2021
9b7f85f
Merge branch 'develop' into feature/nemsdriver_cleanup
DeniseWorthen Apr 20, 2021
87c6070
update NEMS
DeniseWorthen Apr 20, 2021
5fbe232
update CMakeList and NEMS for removal of internal states
DeniseWorthen Apr 20, 2021
b88310e
updates for wave template input file
JessicaMeixner-NOAA Apr 21, 2021
781dfa1
Merge remote-tracking branch 'UFS/develop' into firstattemptattemplates
JessicaMeixner-NOAA Apr 21, 2021
6ba165f
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Apr 21, 2021
0a6baf4
Merge branch 'develop' into feature/nemsdriver_cleanup
DeniseWorthen Apr 21, 2021
278efbc
add ww3_multi.inp as a templated parm file instead of being fixed
JessicaMeixner-NOAA Apr 21, 2021
e84dd91
add a gcc module so that gfortran can be found when building
JessicaMeixner-NOAA Apr 22, 2021
83f9c65
update WW3 to its latest develop branch
JessicaMeixner-NOAA Apr 22, 2021
bda4eea
Merge remote-tracking branch 'UFS/develop' into makewavetemplateinput
JessicaMeixner-NOAA Apr 22, 2021
812d6eb
Merge remote-tracking branch 'origin/updateWWgaeamodule' into makewav…
JessicaMeixner-NOAA Apr 22, 2021
cd0b04d
add ATMW tests to all machines except jet leaves C768 as hera/orion only
JessicaMeixner-NOAA Apr 22, 2021
9774528
update for better load balancing of wave tests
JessicaMeixner-NOAA Apr 22, 2021
1602558
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Apr 22, 2021
c4ae666
update NEMS
DeniseWorthen Apr 22, 2021
4cc37e3
Merge branch 'develop' into feature/nemsdriver_cleanup
DeniseWorthen Apr 22, 2021
37d6c91
fix for multiple wave grids with template
JessicaMeixner-NOAA Apr 23, 2021
234fe26
Merge remote-tracking branch 'UFS/develop' into makewavetemplateinput
JessicaMeixner-NOAA Apr 26, 2021
5e438df
update to latest WW3
JessicaMeixner-NOAA Apr 26, 2021
3e54244
update ATMW to use existing format for output and include gaea for S2SW
JessicaMeixner-NOAA Apr 26, 2021
2208dea
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Apr 26, 2021
43ea95f
revert unintended changes
JessicaMeixner-NOAA Apr 26, 2021
de7086e
add CPLWAV=F to datm section of defaults
JessicaMeixner-NOAA Apr 26, 2021
ac10e5a
orion log when creating new baseline passed
JessicaMeixner-NOAA Apr 27, 2021
804bdbf
Add datm and coupled tests to Jet.
binli2337 Apr 27, 2021
217e3f0
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Apr 27, 2021
483986a
update NEMS
DeniseWorthen Apr 27, 2021
dc4154e
Merge branch 'develop' into feature/nemsdriver_cleanup
DeniseWorthen Apr 27, 2021
e5995a6
Merge branch 'develop' into feature/jet_test2
binli2337 Apr 28, 2021
c553a61
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Apr 28, 2021
eb52d93
Merge branch 'develop' into feature/nemsdriver_cleanup
DeniseWorthen Apr 28, 2021
568591b
Merge remote-tracking branch 'UFS/develop' into makewavetemplateinput
JessicaMeixner-NOAA Apr 29, 2021
52a49cf
Merge remote-tracking branch 'JessicaMeixner/makewavetemplateinput' i…
DeniseWorthen Apr 29, 2021
fbeda95
Merge remote-tracking branch 'BinLi/feature/jet_test2' into feature/n…
DeniseWorthen Apr 29, 2021
52625f5
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Apr 30, 2021
86105a1
Merge branch 'develop' into feature/nemsdriver_cleanup
DeniseWorthen Apr 30, 2021
a248612
Merge remote-tracking branch 'upstream/develop' into develop
DeniseWorthen Apr 30, 2021
ab96ec5
Merge branch 'develop' into feature/nemsdriver_cleanup
DeniseWorthen Apr 30, 2021
b2332ad
RT JOBS PASSED: jet.intel. Log file uploaded.
BrianCurtis-NOAA May 1, 2021
f28a43a
revert un-intended merge of ww3 branch
DeniseWorthen May 3, 2021
486e9b7
update submodules
DeniseWorthen May 3, 2021
3bdf5a2
RT JOBS PASSED: hera.gnu. Log file uploaded.
BrianCurtis-NOAA May 3, 2021
29cded0
RT JOBS PASSED: hera.intel. Log file uploaded.
BrianCurtis-NOAA May 3, 2021
4f593f9
run-ci
DeniseWorthen May 3, 2021
19c7f41
add wcoss-cray log
DeniseWorthen May 3, 2021
d8a7736
RT JOBS PASSED: cheyenne.gnu. Log file uploaded.
BrianCurtis-NOAA May 3, 2021
d8c36f9
RT JOBS PASSED: cheyenne.intel. Log file uploaded.
BrianCurtis-NOAA May 3, 2021
1d17ebd
RT JOBS PASSED: gaea.intel. Log file uploaded.
BrianCurtis-NOAA May 3, 2021
3c1d93e
RT JOBS PASSED: orion.intel. Log file uploaded.
BrianCurtis-NOAA May 3, 2021
f4d2360
add wcoss_dell_p3 log
DeniseWorthen May 3, 2021
6d5e852
RT JOBS PASSED: jet.intel. Log file uploaded.
BrianCurtis-NOAA May 3, 2021
57ae9c9
revert submodules
DeniseWorthen May 3, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
branch = develop
[submodule "NEMS"]
path = NEMS
url = https://github.com/NOAA-EMC/NEMS
branch = develop
#url = https://github.com/NOAA-EMC/NEMS
#branch = develop
url = https://github.com/DeniseWorthen/NEMS
branch = feature/nemsdriver_cleanup
[submodule "FMS"]
path = FMS
url = https://github.com/NOAA-GFDL/FMS
Expand Down
5 changes: 0 additions & 5 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -247,12 +247,7 @@ endif()
### UFS Library [NEMS]
###############################################################################
list(APPEND _nems_srcs NEMS/src/module_NEMS_UTILS.F90
NEMS/src/module_MEDIATOR_methods.F90
NEMS/src/module_MEDIATOR.F90
NEMS/src/module_MEDIATOR_SpaceWeather.F90
NEMS/src/module_EARTH_INTERNAL_STATE.F90
NEMS/src/module_EARTH_GRID_COMP.F90
NEMS/src/module_NEMS_INTERNAL_STATE.F90
NEMS/src/module_NEMS_GRID_COMP.F90
NEMS/src/module_NEMS_Rusage.F90
NEMS/src/nems_c_rusage.c)
Expand Down
2 changes: 1 addition & 1 deletion WW3
Submodule WW3 updated 40 files
+10 −0 .github/ISSUE_TEMPLATE/add-development-request.md
+23 −0 .github/ISSUE_TEMPLATE/bug_report.md
+15 −0 .github/ISSUE_TEMPLATE/documentation.md
+20 −0 .github/ISSUE_TEMPLATE/feature_request.md
+43 −0 .github/pull_request_template.md
+4 −0 .gitignore
+2 −1 model/bin/comp.tmpl
+1 −1 model/bin/link.tmpl
+11 −1 model/bin/make_makefile.sh
+3 −2 model/bin/w3_make
+2 −2 model/bin/ww3_from_ftp.sh
+42 −0 model/ftn/PDLIB/yowpdlibmain.ftn
+4 −0 model/ftn/SCRIP/scrip_grids.f
+5 −1 model/ftn/w3gsrumd.ftn
+2 −2 model/ftn/w3iopomd.ftn
+2 −2 model/ftn/w3odatmd.ftn
+16 −5 model/ftn/w3tidemd.ftn
+118 −17 model/ftn/w3triamd.ftn
+156 −22 model/ftn/wmscrpmd.ftn
+2 −2 model/ftn/wmupdtmd.ftn
+91 −2 model/ftn/ww3_grid.ftn
+154 −55 model/ftn/ww3_prnc.ftn
+4 −4 model/ftn/ww3_shel.ftn
+10 −0 regtests/bin/matrix.base
+128 −0 regtests/bin/matrix_divider_p.sh
+131 −0 regtests/bin/matrix_milhydro
+70 −58 regtests/bin/matrix_ncep
+2 −2 regtests/mww3_test_04/input/ww3_multi_grdset_d.inp
+2 −1 regtests/mww3_test_04/input/ww3_multi_grdset_d.nml
+2 −2 regtests/ww3_tp2.14/input/oasis3-mct/util/make_dir/cmplr.tmpl
+41 −0 regtests/ww3_tp2.21/info
+1 −0 regtests/ww3_tp2.21/input/switch_NO_PDLIB
+1 −0 regtests/ww3_tp2.21/input/switch_PDLIB
+36 −0 regtests/ww3_tp2.21/input/ww3_grid_a.inp
+60 −0 regtests/ww3_tp2.21/input/ww3_grid_b.inp
+83 −0 regtests/ww3_tp2.21/input/ww3_ounf.inp
+117 −0 regtests/ww3_tp2.21/input/ww3_ounp.inp
+51 −0 regtests/ww3_tp2.21/input/ww3_prnc.inp
+443 −0 regtests/ww3_tp2.21/input/ww3_shel.inp
+72 −0 regtests/ww3_tp2.21/input/ww3_strt.inp
3 changes: 3 additions & 0 deletions modulefiles/ufs_gaea.intel
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ setenv CMAKE_CXX_COMPILER CC
setenv CMAKE_Fortran_COMPILER ftn
setenv CMAKE_Platform gaea.intel

#needed for WW3 build
module load gcc/8.3.0

module use /lustre/f2/pdata/esrl/gsd/ufs/hpc-stack-v1.1.0/modulefiles/stack

module load hpc/1.1.0
Expand Down
150 changes: 75 additions & 75 deletions tests/RegressionTests_cheyenne.gnu.log

Large diffs are not rendered by default.

476 changes: 238 additions & 238 deletions tests/RegressionTests_cheyenne.intel.log

Large diffs are not rendered by default.

436 changes: 218 additions & 218 deletions tests/RegressionTests_gaea.intel.log

Large diffs are not rendered by default.

150 changes: 75 additions & 75 deletions tests/RegressionTests_hera.gnu.log

Large diffs are not rendered by default.

492 changes: 246 additions & 246 deletions tests/RegressionTests_hera.intel.log

Large diffs are not rendered by default.

2,297 changes: 2,013 additions & 284 deletions tests/RegressionTests_jet.intel.log

Large diffs are not rendered by default.

314 changes: 157 additions & 157 deletions tests/RegressionTests_wcoss_cray.log

Large diffs are not rendered by default.

41 changes: 39 additions & 2 deletions tests/default_vars.sh
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,42 @@ elif [[ $MACHINE_ID = jet.* ]]; then
TASKS_stretch=48 ; TPN_stretch=12 ; INPES_stretch=2 ; JNPES_stretch=4
TASKS_strnest=96 ; TPN_strnest=12 ; INPES_strnest=2 ; JNPES_strnest=4

TASKS_cpl_dflt=192; TPN_cpl_dflt=24; INPES_cpl_dflt=3; JNPES_cpl_dflt=8
THRD_cpl_dflt=1; WPG_cpl_dflt=6; MPB_cpl_dflt="0 143"; APB_cpl_dflt="0 149"
OPB_cpl_dflt="150 179"; IPB_cpl_dflt="180 191"

TASKS_cpl_dflt_wwav=204; TPN_cpl_dflt_wwav=24; INPES_cpl_dflt_wwav=3; JNPES_cpl_dflt_wwav=8
THRD_cpl_dflt_wwav=1; WPG_cpl_dflt_wwav=6; MPB_cpl_dflt_wwav="0 143"; APB_cpl_dflt_wwav="0 149"
OPB_cpl_dflt_wwav="150 179"; IPB_cpl_dflt_wwav="180 191"; WPB_cpl_dflt_wwav="192 203"

TASKS_cpl_thrd=120; TPN_cpl_thrd=18; INPES_cpl_thrd=3; JNPES_cpl_thrd=4
MinsukJi-NOAA marked this conversation as resolved.
Show resolved Hide resolved
THRD_cpl_thrd=2; WPG_cpl_thrd=6; MPB_cpl_thrd="0 77"; APB_cpl_thrd="0 77"
OPB_cpl_thrd="78 107"; IPB_cpl_thrd="108 119"

TASKS_cpl_bmrk=480; TPN_cpl_bmrk=24; INPES_cpl_bmrk=6; JNPES_cpl_bmrk=8
THRD_cpl_bmrk=1; WPG_cpl_bmrk=24; MPB_cpl_bmrk="0 287"; APB_cpl_bmrk="0 311"
OPB_cpl_bmrk="312 431"; IPB_cpl_bmrk="432 479"

TASKS_cpl_wwav=520; TPN_cpl_wwav=24; INPES_cpl_wwav=6; JNPES_cpl_wwav=8
THRD_cpl_wwav=1; WPG_cpl_wwav=24; MPB_cpl_wwav="0 287"; APB_cpl_wwav="0 311"
OPB_cpl_wwav="312 431"; IPB_cpl_wwav="432 479"; WPB_cpl_wwav="480 519"

TASKS_cpl_c192=288; TPN_cpl_c192=24; INPES_cpl_c192=4; JNPES_cpl_c192=8
THRD_cpl_c192=1; WPG_cpl_c192=12; MPB_cpl_c192="0 191"; APB_cpl_c192="0 203"
OPB_cpl_c192="204 263"; IPB_cpl_c192="264 287"

TASKS_cpl_c384=480; TPN_cpl_c384=24; INPES_cpl_c384=6; JNPES_cpl_c384=8
THRD_cpl_c384=1; WPG_cpl_c384=24; MPB_cpl_c384="0 287"; APB_cpl_c384="0 311"
OPB_cpl_c384="312 431"; IPB_cpl_c384="432 479"

TASKS_datm_100=120; TPN_datm_100=24
MPB_datm_100="16 77"; APB_datm_100="0 15"
OPB_datm_100="78 107"; IPB_datm_100="108 119"

TASKS_datm_025=208; TPN_datm_025=24
MPB_datm_025="0 39"; APB_datm_025="0 39"
OPB_datm_025="40 159"; IPB_datm_025="160 207"

elif [[ $MACHINE_ID = gaea.* ]]; then

TASKS_dflt=150 ; TPN_dflt=36 ; INPES_dflt=3 ; JNPES_dflt=8
Expand Down Expand Up @@ -510,7 +546,7 @@ export CPL_FAST=${DT_ATMOS}

# nems.configure defaults
export NEMS_CONFIGURE="nems.configure.cpld.IN"
export med_model="nems"
export med_model="cmeps"
export atm_model="fv3"
export ocn_model="mom6"
export ice_model="cice6"
Expand Down Expand Up @@ -619,6 +655,7 @@ export_datm ()
{
export FV3=false
export S2S=false
export CPLWAV=.F.
export DATM=true
export DAYS=1
export FHMAX=24
Expand All @@ -642,7 +679,7 @@ export NY_GLB=320

# nems.configure
export NEMS_CONFIGURE="nems.configure.datm.IN"
export med_model="nems"
export med_model="cmeps"
export atm_model="datm"
export ocn_model="mom6"
export ice_model="cice6"
Expand Down
6 changes: 3 additions & 3 deletions tests/parm/nems.configure.datm.IN
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ DRIVER_attributes::
mediator_read_restart = @[use_coldstart]
::
MED_attributes::
ATM_model = datm
ICE_model = cice6
OCN_model = mom
ATM_model = @[atm_model]
ICE_model = @[ice_model]
OCN_model = @[ocn_model]
history_n = 1
history_option = nhours
history_ymd = -999
Expand Down
Loading