abort on missing files, add cmeps #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DATM updates and fixes (NOAA-EMC#8)
junwang-noaa
reviewed
Jun 4, 2020
Initialize fpresent
|
I just realized I hadn't merged my cpl_scalars branch (needed for CMEPS) after all. I will do that and re-run the regression tests. |
|
@binli2337, @flampouris : This PR is ready now. Could you review? Thanks. |
junwang-noaa
approved these changes
Jun 9, 2020
binli2337
approved these changes
Jun 9, 2020
flampouris
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues #12 , #10:
adds abort if DATM input file is missing. Abort message will be written to PET logs and default log file. This feature was tested by attempting to integrate in time past the available data input files. The model aborted as expected.
adds cpl_scalars for use with CMEPS
simplifies the setting of the run clock
adds dbug_flag read from nems.configure to control message printing. Setting dbug_flag = 0 will suppress message printing. Setting dbug_flag > 5 will print all messages.
removes additional importstate instances where possible
Verification that the DATM clock is working and advancing as expected is shown here. Black dots are the export values over 24 hours from initial time 2011-10-01-00 at a single location on the global grid. Values exported from the DATM at each timestep are show as black dots; the blue dots are the values in the 6-hourly forcing files. Only CFSR is shown.