Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving bugs with build and clone processes #151

Merged

Conversation

SamuelDegelia-NOAA
Copy link
Contributor

@SamuelDegelia-NOAA SamuelDegelia-NOAA commented Sep 5, 2024

This PR makes a few minor changes to resolve bugs associated with building and cloning, including:

  1. Resolving CMake failed on Orion/Hercules #144 by updating the documentation to note the need to run module load git-lfs before cloning on Orion.
  2. Resolving FYI, conda: command not found when building under the EVA python environment #135 by adding module purge to the beginning of build.sh. Previously, if you had the eva modules loaded, build.sh would fail. This quick change prevents that error by forcing you to unload all modules before building.
  3. Modifying link_mpasjedi_expr.sh by adding the ${BUMPLOC} directory name to prevent a linking error during build on Orion. Previously, the linking failed on due to the link directory not being specified which lead to cannot overwrite directory error. This error did not occur on Hera.

Note that there is still an ongoing bug with building on Orion (#146). Restarting the build resolves that issue, but I am still actively investigating the root cause.

docs/build_and_test.md Outdated Show resolved Hide resolved
docs/build_and_test.md Outdated Show resolved Hide resolved
TingLei-NOAA
TingLei-NOAA previously approved these changes Sep 6, 2024
Copy link
Collaborator

@guoqing-noaa guoqing-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for fixing these bugs and addressing my picky comments.

@guoqing-noaa guoqing-noaa merged commit fcb2f16 into NOAA-EMC:develop Sep 6, 2024
1 check passed
@SamuelDegelia-NOAA SamuelDegelia-NOAA deleted the feature/build_bugfix branch September 6, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants