Update exglobal_atmos_pmgr.sh with the feedback of NCO's parallel run. #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KateFriedman-NOAA
approved these changes
Jan 5, 2021
|
@KateFriedman-NOAA Thanks for the code review. |
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
) * This change makes the location of the make_orog fix files more flexible. Previously, in exregional_make_orog.sh, a local variable "topo_dir" was used as the location of the fix files for the make_orog task, and this variable was hard-coded as a path relative to the global "FIXgsm" variable. Now topo_dir is set as a global variable in setup.sh, just like FIXgsm and SFC_CLIMO_INPUT_DIR, to allow more flexibility for the location of these fixed input files. * Make the fix file directories (FIXgsm, topo_dir, and SFC_CLIMO_INPUT_DIR) user-configurable through config.sh * Fix some comments and variable names per PR comments
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update exglobal_atmos_pmgr.sh with the feedback of NCO's parallel run.