Trigger postanl job reliable #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KateFriedman-NOAA
approved these changes
May 25, 2021
scripts/exglobal_atmos_pmgr.sh
Outdated
Comment on lines
50
to
57
| if [ $fhr -eq 0 ] | ||
| then | ||
| #### ecflow_client --event release_${RUN}_postanl | ||
| ecflow_client --event release_postanl | ||
| if [ -s ${COMIN}/${RUN}.${cycle}.loganl.txt ] | ||
| then | ||
| ecflow_client --event release_postanl | ||
| fi | ||
| fi |
There was a problem hiding this comment.
Maybe compress this if-block to become:
if [ $fhr -eq 0 -a -s ${COMIN}/${RUN}.${cycle}.loganl.txt ]
then
ecflow_client --event release_postanl
fi
Unless there are plans to add additional cases/if-statements to the if [ $fhr -eq 0 ] block.
There was a problem hiding this comment.
@KateFriedman-NOAA Good suggestion! I have been waiting for @lgannoaa comments and assume the changes were tested by Lin in ecflow.
|
@lgannoaa Would you like tweaking based on Kate's suggestion? |
|
@WenMeng-NOAA , |
|
@lgannoaa Sure. I will commit the current changes soon. We might optimize the workflow scripts in the future. Thanks! |
lgannoaa
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update exglobal_atmos_pmgr.sh from Lin Gan to trigger postanl job reliable.