grib1 cleanup #410
grib1 cleanup #410
Conversation
…T_GFS_NEMS.f, INITPOST_GFS_SIGIO.f from CMakeLists.txt, remove unused variables from a number of INITPOST* routines that were initialized in RQSTFLD.F
|
@hertneky Could you sync your branch with upstream/develop? |
|
@WenMeng-NOAA Sync'd |
|
@hertneky The READCNTRL.F is not in the compiling list any more. Do you think it can be removed from sorc/ncep_post.fd? |
|
@WenMeng-NOAA Yes, READCNTRL.F can be removed from the directory. |
|
@hertneky Since all grib1 settings are removed from RQSTFLD.F, do you think this file name can be changed back to RQSTFLD.f which would have consistency with most of UPP routines? |
|
Yes that makes sense for consistency. Should we keep the name RQSTFLD as is? Either way I can tack on a line in the history of this revision too. |
|
@hertneky I might think using RQSTFLD.f would be easy for searching something during debugging. Please add your change logs in related source code files. |
|
@hertneky Do you have any updates on your branch? |
|
@WenMeng-NOAA The additional mods had caused all runs to fail except GFS, which ran and was bit-wise identical. I had not had the time to look at exactly which change caused the failures. I can look into this now. |
|
@WenMeng-NOAA Sorry for the delay. The UPP team apparently has resource issues and my jobs sat in queue much of yesterday. There were no issues with running, I just needed to update the scripts. All tests on Hera passed with additional mods. |
WenMeng-NOAA
added
No Baseline Change
|
@fossell Please let me know if you have more comments. Thanks! |
|
The UPP regression tests were successfully completed on WCOSS-Dell, WCOSS-Cray and Hera. No changed results were found. This PR is ready for merging. |
No description provided.