Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icnt value increase with NCO's feedback #478

Merged
merged 1 commit into from
Apr 13, 2022
Merged

icnt value increase with NCO's feedback #478

merged 1 commit into from
Apr 13, 2022

Conversation

WenMeng-NOAA
Copy link
Collaborator

Increase icnt value from 1000 to 1080 in exglobal_atmos_pmgr.sh with NCO's feedback.

KateFriedman-NOAA
KateFriedman-NOAA approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to icnt looks good and is as discussed between @WenMeng-NOAA and @WeiWei-NCO. Thanks!

@WenMeng-NOAA
Copy link
Collaborator Author

@KateFriedman-NOAA I plan to cut the new UPP tag as upp_v8.1.2. Please let me know if it works for the global-workflow. Thanks!

@KateFriedman-NOAA
Copy link
Member

@KateFriedman-NOAA I plan to cut the new UPP tag as upp_v8.1.2. Please let me know if it works for the global-workflow. Thanks!

That works for global-workflow, thanks! I'll proceed with updating the UPP tag name in global-workflow feature/ops-wcoss2 and include it in the new tag for NCO. Please confirm once the new UPP upp_v8.1.2 tag is cut. Thanks!

@WenMeng-NOAA WenMeng-NOAA merged commit aeb1213 into NOAA-EMC:release/gfs_v16 Apr 13, 2022
@WenMeng-NOAA WenMeng-NOAA added bug Something isn't working GFSV16 labels Apr 13, 2022
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Apr 13, 2022
Open
@WenMeng-NOAA
Copy link
Collaborator Author

@KateFriedman-NOAA The new tag upp_v8.1.2 was created. Please let me know if you see issues. Thanks!

@KateFriedman-NOAA
Copy link
Member

The new tag upp_v8.1.2 was created. Please let me know if you see issues. Thanks!

@WenMeng-NOAA I tested checkout and build of the new tag...no issues. Looks good, thanks for cutting the new tag!

@WenMeng-NOAA WenMeng-NOAA deleted the gfsv16_nco_wcoss2_3 branch October 11, 2022 13:47
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Feb 15, 2023
@chunhuazhou
Bug fixes for Ensemble DA (NOAA-EMC#478)
713008a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

Assignees
No one assigned
Labels
bug Something isn't working GFSV16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WenMeng-NOAA @KateFriedman-NOAA