Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master HotFix: ounfpart + NCO switch + DB1 coeff (v6.07.1) #14

Merged
merged 3 commits into from
Apr 19, 2019

Conversation

ajhenrique
Copy link
Collaborator

@ajhenrique ajhenrique commented Apr 19, 2019

HF ounfpart integrates hotfixes from the NCEP/NOAA-EMC auth repo and the trusted repos UKMO and ERDC. The following hotfixes are implemented with this pull request:

  • Bugfix in ww3_ounf.ftn: NBIPART check against NOSWLL was not accouting for zeroth wind partition. See Issue Partition number checking failing in ww3_ounf #2.
  • Updating link.wcoss_phase2 for grib compile, removing !$ lines in ww3_uprstr that broke compilation of codes with OMPH OMPG switch flags, added new global wave model switch. Added option for writing to fixed netcdf gridded output file when using NCO switch (the issue will be fixed more adequately in v7 following Issue Netcdf gridded output to file with fixed name #8).
  • DB1 depth-breaking_bugfix: added proper scaling coefficients for radian freq. [radHz]. See issue Depth breaking DB1 bug #7 .

Hotfixes were tested using the full regression testing matrix at NCEP which resulted in differences only in regtests wher DB1 was employed, as expected.

ukmo-ccbunney and others added 3 commits April 4, 2019 09:54
Merging hotfix branch ukmo-waves:HF_ounfpart -> NOAA-EMC/WW3:HF_ounfpart:

* Bugfix in ww3_ounf.ftn: NBIPART check against NOSWLL was not accouting for zeroth wind partition. See Issue #2.

* Updated comments

* Moved broken ww3_grid*.nml files into subdirectory within input dir.
Updated info to stress that test needs to be run with -N flag.
Accepting HF that contains several changes needed for version 6.07 to work for NCEP applications: * Branch HF_NCOswitch_ndso: Changing README.md TM->R, adding grib2 link options to link, creating switch for GLWU, changing w3_make to allow grib compilation

* Branch HF_NCOswitch_ndso: Updating link.wcoss_phase2 for grib compile, fixing OMPH OMPG switch flags that broke uprstr compilation, added new global wave model switch

* Branch HF_NCOswitch_ndso: reverting change in ounf that belongs to UKMO branch
Adding bugfix to depth breaking DB1.

* breaking_bugfix: add proper scaling for radian freq. [radHz]

* breaking_bugfix: Add some comments ...

* update comments ...

* update comments ...

* changed version number in header from 7.00 to 6.07

* minor formatting fix on header
@ajhenrique ajhenrique self-assigned this Apr 19, 2019
@ajhenrique ajhenrique changed the title Hf ounfpart HF ounfpart + NCO switch + DB1 coeff Apr 19, 2019
@ajhenrique ajhenrique merged commit b582f8c into master Apr 19, 2019
@ajhenrique ajhenrique deleted the HF_ounfpart branch April 19, 2019 14:53
@ajhenrique ajhenrique changed the title HF ounfpart + NCO switch + DB1 coeff master HotFix: ounfpart + NCO switch + DB1 coeff (v6.07.1) Apr 19, 2019
@ajhenrique ajhenrique restored the HF_ounfpart branch April 23, 2019 21:26
@ajhenrique ajhenrique deleted the HF_ounfpart branch April 23, 2019 21:48
aliabdolali pushed a commit that referenced this pull request Sep 25, 2020
* Fb rtd2 (#7)

FB_rtd2: Output boundary conditions to rotated grids

* This feature allows the user to specify the pole of each nested grid output of boundary conditions (nest) file.
  - There is no effect unless the switch RTD is set for compilation.
  - The contents of b.c. output files nestI.ww3 are not affected.
  - A model compiled with combined switches SMC and RTD is not affected.

* Updated manual Sec. "3.4.9 Rotated grids"

* Added regtests for testing input/output BCs in rotated pole context.

* Updated revision of ww3_bound.ftn to 7.11

* Added new ww3_tr1 regtest (rotated pole) to matrix.base. Also, split the SMC/RTD regtests into their own separate switches.

Co-authored-by: ukmo-chris.bunney <christopher.bunney@metoffice.gov.uk>

* Double allocation error of FIELD variable [w3wavemd] (#14)

* Fixed allocation of FIELD variable.
* Removed defunct OMPX switches and FLOMP variable

* Change coupling condition so that it works with all compilers (#12)

Co-authored-by: Carsten Hansen <cha@fcoo.dk>
Co-authored-by: Juan Manuel Castillo Sanchez <48921434+ukmo-juan-castillo@users.noreply.github.com>
MatthewMasarik-NOAA pushed a commit that referenced this pull request Oct 18, 2023
* ensure lat array, for the loop, is ok while dowloading AODN data in the Southern Hemisphere.

* SENTINEL-3B included. Longitude standard checked

* fixed long issues

* header text improved
mvertens pushed a commit to mvertens/WW3 that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants