-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UKMO Staging (Oct 2020) #264
Conversation
In the original code a coupling lag had to be used, coupling took place at the last time step but not at the first, and the coupling fields had to be written in an oasis restart file. With this ticket, the program can run in a different way by not using a coupling lag, coupling taking place at the first time step but not the last, and the coupling fields are written in the wave restart file - no extra oasis restart file needed.
Enhancement to improve the way in which input data is read in and logged by the ww3_uprstr program: * read in variables specific to the update process selected * output the values provided in the ww3_uprstr.out log file * update the .inp template file and regtests to improve clarity and work with the changes * add capability to read inputs from a namelist (ww3_uprstr.nml) file
* Fix non-conforming WHERE statements in coupled routines * Stop comparing history lines in OASIS rmp files
* Changes for efficient SMC grid coupling * Ensure consistency between SMC coupled test nml and inp files
Hi @ukmo-ccbunney |
Hi @aliabdolali - the required update should already be in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ukmo-ccbunney Looks good to me.
I have checked the matrix on NOAA HPC and the expected differences |
@ukmo-ccbunney Please close any related issues which are resolved here. |
Great - many thanks @aliabdolali . |
Details
This PR comprises 4 indivudal PRs raised and reviewed on the UKMO WW3 repo:
Additional files
Two new files need to be added to the
ww3_from_ftp.*.tar.gz
regtests data distribution file for the new OASIS SMC regression test. The files are attached here: https://github.com/ukmo-waves/WW3/files/5347030/weights.zipRegression Testing
The full regression test matrix results are attached: maxtrixComp_staging_oct20.zip
Expected differences:
restart.ww3
files due changes made for PR13 (OASIS T+0 coupling). For all non-coupled runs, the difference is just a change of the internal version string to2020-09-25
ww3_ta1
: Small text changes toww3_grid.out
andww3_uprstst.out
log files relating to PR15.Known existing differences:
mww3_test_03
: Not b4b.ww3_tp2.18/TIDE_MPI
: Differences in order of debug lines inww3_prtide_current.out
log file when run in MPI mode.