Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UKMO Staging (Oct 2020) #264

Merged
merged 4 commits into from
Nov 5, 2020
Merged

Conversation

ukmo-ccbunney
Copy link
Collaborator

Details

This PR comprises 4 indivudal PRs raised and reviewed on the UKMO WW3 repo:

Additional files

Two new files need to be added to the ww3_from_ftp.*.tar.gz regtests data distribution file for the new OASIS SMC regression test. The files are attached here: https://github.com/ukmo-waves/WW3/files/5347030/weights.zip

Regression Testing

The full regression test matrix results are attached: maxtrixComp_staging_oct20.zip

Expected differences:

  • ALL regtests show differences in the generated restart.ww3 files due changes made for PR13 (OASIS T+0 coupling). For all non-coupled runs, the difference is just a change of the internal version string to 2020-09-25
  • ww3_ta1: Small text changes to ww3_grid.out and ww3_uprstst.out log files relating to PR15.
  • New regression tests for OASIS coupling (OASACM3, OASACM4, OASACM5 and OASACM6)

Known existing differences:

  • mww3_test_03: Not b4b.
  • ww3_tp2.18/TIDE_MPI: Differences in order of debug lines in ww3_prtide_current.out log file when run in MPI mode.

ukmo-juan-castillo and others added 4 commits October 28, 2020 11:14
In the original code a coupling lag had to be used, coupling took place at the last time step but not at the first, and the coupling fields had to be written in an oasis restart file. With this ticket, the program can run in a different way by not using a coupling lag, coupling taking place at the first time step but not the last, and the coupling fields are written in the wave restart file - no extra oasis restart file needed.
Enhancement to improve the way in which input data is read in and logged by the ww3_uprstr program:
  * read in variables specific to the update process selected
  * output the values provided in the ww3_uprstr.out log file
  * update the .inp template file and regtests to improve clarity and work with the changes
  * add capability to read inputs from a namelist (ww3_uprstr.nml) file
* Fix non-conforming WHERE statements in coupled routines
* Stop comparing history lines in OASIS rmp files
* Changes for efficient SMC grid coupling
* Ensure consistency between SMC coupled test nml and inp files
@ukmo-ccbunney ukmo-ccbunney added the enhancement New feature or request label Oct 29, 2020
@aliabdolali
Copy link
Contributor

Hi @ukmo-ccbunney
I am running the matrix on our HPC.
I also updated the tar file on ftp, could you update mode/bin/ww3_from_ftp.sh?
https://ftp.emc.ncep.noaa.gov/static_files/public/WW3/ww3_from_ftp.v7.07.tar.gz

@ukmo-ccbunney
Copy link
Collaborator Author

ukmo-ccbunney commented Nov 5, 2020

Hi @ukmo-ccbunney
I am running the matrix on our HPC.
I also updated the tar file on ftp, could you update mode/bin/ww3_from_ftp.sh?
https://ftp.emc.ncep.noaa.gov/static_files/public/WW3/ww3_from_ftp.v7.07.tar.gz

Hi @aliabdolali - the required update should already be in ww3_from_ftp.sh:
https://github.com/ukmo-waves/WW3/blame/426d42349f54faf3b0f90569e120807eac2778d9/model/bin/ww3_from_ftp.sh#L40

Copy link
Contributor

@aliabdolali aliabdolali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ukmo-ccbunney Looks good to me.

@aliabdolali
Copy link
Contributor

I have checked the matrix on NOAA HPC and the expected differences
matrix_diff_ukmet_staging_NOAA.zip
are the same as the ones reported by UKMET.

@aliabdolali aliabdolali merged commit e756361 into NOAA-EMC:develop Nov 5, 2020
@aliabdolali
Copy link
Contributor

@ukmo-ccbunney Please close any related issues which are resolved here.

@ukmo-ccbunney
Copy link
Collaborator Author

I have checked the matrix on NOAA HPC and the expected differences
matrix_diff_ukmet_staging_NOAA.zip
are the same as the ones reported by UKMET.

Great - many thanks @aliabdolali .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants