Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop to dev/ufs-weather-model branch 20220324 #648

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

Pull Request Summary

Created a branch of dev/ufs-weather-model and then merged the develop branch to that. The most relevant update for dev/ufs-weather-model is the bug-fix for properly passing debug flags to WW3. This fix was provided by @kgerheiser .

Testing

  • The testing of this PR is through the ufs-weather-model. This PR will not be merged until it has passed all ufs-weather-model regression tests and be committed right before the top level PR will also be merged.

MatthewMasarik-NOAA and others added 15 commits February 1, 2022 10:03
wmesmfmd: initialization of tauwx,tauwy
ww3_doxy_tmpl.md, Doxyfile.in fixes
and  fix it to use with namelist files
minor update in the coupling itself to use the same conditions for each exchanged variable.
CMake provides a portable and standardized build system and out-of-source builds. This means a faster and simpler build system. See README for more documentation.
> Clear flags that come from UFS when building as submodule
> Conflicting flags from UFS would enter WW3 build. Check if building as subdirectory and then clear CMAKE_<lang>_FLAGS
Fix Github Action builds.
…OAA-EMC#633)

TOC total momentum to ocean added in documentation and nml/inp files
add -o all option to matrix_cmake_ncep
> Update run_cmake test to exit if the test is completed before building
> clear debug flags in cmake if built from a parent repo.
…0324

 Conflicts:
	CMakeLists.txt
	regtests/bin/matrix_cmake_ncep
	regtests/bin/run_cmake_test
@JessicaMeixner-NOAA JessicaMeixner-NOAA added the UFS issues related to coupling WW3 in the Unified Forecast System (UFS) label Mar 25, 2022
@JessicaMeixner-NOAA
Copy link
Collaborator Author

@aliabdolali this is ready to be merged. See testing: ufs-community/ufs-weather-model#1130

@aliabdolali aliabdolali merged commit d00e431 into NOAA-EMC:dev/ufs-weather-model Apr 12, 2022
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the merge-dev-to-ufs-20220324 branch April 13, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UFS issues related to coupling WW3 in the Unified Forecast System (UFS)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants