-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doxygen marked source - PR3 #748
Conversation
Conflicts: model/src/constants.F90
@ukmo-ccbunney @mickaelaccensi We are seeing differences in the file OUTPUT_TOY.txt in test ww3_tp2.14/./work_OASICM below differs by one line of text, APPLE partitioning. Could you take a look and let us know if you know why it happens? This PR is for deoxygenizing the modules and routines. |
I ran the regtests twice and did not encounter the same issue @MatthewMasarik-NOAA have seen, so I approve this PR and proceed with the merge.
|
Pull Request Summary
Collection of
doxygen
marked files.Description
The following list of files has been marked with
doxygen
tags for documentation:Is a change of answers expected from this PR?
No. Documentation only added. However, there is one small change described below.
Please also include the following information:
Issue(s) addressed
Commit Message
Doxygen documentation - marked source PR 3
Co-author: @JessicaMeixner-NOAA
Check list
Testing
How were these changes tested?
#ifdef
block. The block toggles optional input to a subroutine call in w3wavemd.F90 and may be difficult to remove entirely.)Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
No. The changes are only documentation. Documentation is not tested.
Have the matrix regression tests been run (if yes, please note HPC and compiler)?
Yes. Hera / Intel.
Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
No expected changes except for the known non-identical tests and unstructured grid mod_defs. That said, there is one change to a text log file mentioned below.
Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
Note: the file
OUTPUT_TOY.txt
in the testww3_tp2.14/./work_OASICM
below differs by one line of text,APPLE partitioning
. The repo under review contains this line as shown in the screenshot below, whereas the same file in the develop branch does not have it at this location. Both files do have the same line appearing lower down in the file. This is the third time matrix has been run, and each time the same result.matrixDiff.txt
matrixCompSummary.txt
matrixCompFull.txt
new.OUTPUT_TOY.txt
dev.OUTPUT_TOY.txt