Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the hash of the spack.yaml as part of the Github Action cache key #752

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Use the hash of the spack.yaml as part of the Github Action cache key #752

merged 1 commit into from
Aug 8, 2022

Conversation

kgerheiser
Copy link
Contributor

@kgerheiser kgerheiser commented Aug 4, 2022

Pull Request Summary

Now, whenver the spack.yaml changes the CI will rebuild the dependencies.

Currently they can go stale unless the cache key is manually changed.

Also, cancel in-progress workflows when pushing to a branch to avoid duplicate workflow runs.

Issue(s) addressed

Fix #751

Commit Message

Use the hash of the spack.yaml as part of the Github Action cache key
Cancel in-progress workflows when pushing to a branch to avoid duplicate workflow runs.

Check list

Testing

  • Only changes the CI build. The checks should pass when the builds complete.

Now, whenver the spack.yaml changes the CI will rebuild the dependencies. Currently they can go stale unless the cache key is manually changed.

Also, cancel branch workflows when pushing to a branch.
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kgerheiser !!!!

@aliabdolali should we add on the wiki page somewhere about "changing a library" so we can write this down there since we don't do this type of change often and might forget?

@aliabdolali
Copy link
Contributor

The resgtests passed successfully on Hera and guideline is added to the the wiki/code management page.
pre-known non-identical cases:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (9 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4                     (1 files differ)
ww3_tp2.6/./work_ST0                     (1 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@aliabdolali aliabdolali merged commit 9576fc4 into NOAA-EMC:develop Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix automatic tests after w3emc pr
3 participants