Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo in ww3_ounf.nml for tp2.16 #758

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

benoitp-cmc
Copy link
Contributor

@benoitp-cmc benoitp-cmc commented Aug 12, 2022

Pull Request Summary

Corrects typo in ww3_ounf.nml for ww3_tp2.16 regtest. Made netcdf gridded output fail.

Description

Corrects typo in ww3_ounf.nml for ww3_tp2.16 regtest. The typo made netcdf gridded output fail in that regtest.

Please also include the following information:

  • Add any suggestions for a reviewer @mickaelaccensi @JessicaMeixner-NOAA
  • Mention any labels that should be added: bug
  • Are answer changes expected from this PR? Please describe the changes and the reason why in addition to which of the following labels would apply: Regression test (will go back to producing netcdf gridded output if requested)

Issue(s) addressed

Commit Message

Correct typo in ww3_ounf.nml for ww3_tp2.16 regtest

Check list

Testing

  • How were these changes tested? Regression test
  • Are the changes covered by regression tests? N/A
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? rhel-8/icelake-64, Intel oneapi 2022.1.2
  • Please indicate the expected changes in the regression test output: ww3_tp2.16 will produce netcdf gridded output if requested
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    matrixCompSummary.txt
    matrixDiff.txt
    matrixCompFull.txt

@aliabdolali aliabdolali self-requested a review August 15, 2022 17:21
@aliabdolali
Copy link
Contributor

The regtests using *inp ran successfully with pre-known non-b4b cases and the tp2.16 with nml ran successfully with the proposed fix.

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (12 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4                     (1 files differ)
ww3_tp2.6/./work_ST0                     (1 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@aliabdolali aliabdolali merged commit 1e18420 into NOAA-EMC:develop Aug 18, 2022
@benoitp-cmc benoitp-cmc deleted the tp2p16_ounf_typo branch August 18, 2022 12:24
@ukmo-ccbunney
Copy link
Collaborator

Thanks for that fix @benoitp-cmc - that was probably my doing... :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants