Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doxygen marked files. Forth subset. #781

Merged
merged 13 commits into from
Sep 15, 2022

Conversation

MatthewMasarik-NOAA
Copy link
Collaborator

Pull Request Summary

Forth subset of doxygen marked source files.

Description

Provide a detailed description of what this PR does.

  • 10 F90 source files have been marked-up with doxygen tags.

What bug does it fix, or what feature does it add?

  • This PR adds doxygen documentation.

Is a change of answers expected from this PR?

  • No. Only documentation is added.

Please also include the following information:

  • Add any suggestions for a reviewer

    • N/A.
  • Mention any labels that should be added:

    • documentation.
  • Are answer changes expected from this PR? Please describe the changes and the reason why in addition to which of the following labels would apply.

    • No. No active code was edited. Only documentation was added by means of doxygen marked comments.

Issue(s) addressed

  • Please list any issues associated with this PR, including those the PR will fix/close. For example:

Commit Message

Doxygen marked source files, 4th subset.

Check list

Testing

  • How were these changes tested?

    • The full matrix of regtests run against current develop.
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)

    • The changes are not covered by regression tests as we do not test for documentation.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?

    • Yes. Hera / Intel.
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)

    • The only expected changes are the known non-identical tests.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

**********************************************************************                                                          
********************* non-identical cases ****************************                                                          
**********************************************************************                                                          
mww3_test_03/./work_PR2_UNO_MPI_d2                     (12 files differ)                                                        
mww3_test_03/./work_PR1_MPI_d2                     (19 files differ)                                                            
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (15 files differ)                                                      
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)                                                       
mww3_test_03/./work_PR3_UNO_MPI_d2                     (15 files differ)                                                        
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)                                                         
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)                                                        
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)                                                         
ww3_ta1/./work_UPD0F_U                     (0 files differ)                                                                     
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)                                                                 
ww3_tp2.16/./work_MPI_OMPH                     (5 files differ)                                                                 
ww3_tp2.6/./work_ST0                     (1 files differ)                                                                       
ww3_tp2.6/./work_ST4                     (1 files differ)                                                                       
ww3_ufs1.3/./work_a                     (1 files differ)                                                                                                                                                                                    
**********************************************************************                                                          
************************ identical cases *****************************                                                          
**********************************************************************

!>
!> @details Use data stored in NGRIDS in W3GDATMD.
!>
!> @param[in] NDSE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable definitions are:
! NDSE Int. I Error output unit number.
! NDST Int. I Test output unit number.
Can we add that here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Good catch. I'll make that update.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@JessicaMeixner-NOAA
Copy link
Collaborator

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

I have a few more diffs, but they are not unexpected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants