Remove fp1 and thp1

[benoitp-cmc]

Pull Request Summary

Removes FP1 and THP1 from the code as these variables are not used.

Description

Removes FP1 and THP1 from the code as these variables are not used. Does not affect the local calculation of FP1 in w3src2md.

Tidy up the use of INIT_GET_ISEA in w3iogomd (remove unused ones and replace manual definitions).

Please also include the following information:

• Add any suggestions for a reviewer : @JessicaMeixner-NOAA
• Mention any labels that should be added:
• Are answer changes expected from this PR? No

Issue(s) addressed

• fixes remove FP1 and THP1 #803

Commit Message

Remove FP1 and THP1 variables (unused). Cleanup INIT_GET_ISEA in w3iogomd.

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• N/A If a version number update is required, checked the updating version number checklist.
• N/A If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested? Regression tests
• Are the changes covered by regression tests? N/A
• Have the matrix regression tests been run (if yes, please note HPC and compiler)? Yes, rhel-8/icelake-64, Intel oneapi 2022.1.2
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.) No changes because of PR. Expected changes plus local problem with running OMP tests in ww3_ts3; multi crash in ww3_tp2.21/work_ma; matrix.comp sees an extra file on one side in tp2.14 oasis cases but I cannot find it.
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

matrixCompSummary.txt
matrixCompFull.txt
matrixDiff.txt

[JessicaMeixner-NOAA]

@benoitp-cmc I have reviewed the code and everything looks great! I'll start running tests, including merging this with the other PR to confirm if that resolves the debug issues we had there. This looks great, thank you so much!!!! I'll keep you up to date as I run tests.

[JessicaMeixner-NOAA]

Thanks @benoitp-cmc

Only the expected differences in the regtests:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (20 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (18 files differ)
ww3_ta1/./work_UPD0F_U                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.14/./work_OASACM2                     (1 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.17/./work_mb                     (1 files differ)
ww3_tp2.17/./work_b                     (1 files differ)
ww3_tp2.17/./work_mc                     (1 files differ)
ww3_tp2.17/./work_a                     (1 files differ)
ww3_tp2.17/./work_c                     (1 files differ)
ww3_tp2.17/./work_ma                     (1 files differ)
ww3_tp2.17/./work_mc1                     (1 files differ)
ww3_tp2.17/./work_ma1                     (1 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)

matrixDiff.txt
matrixCompFull.txt
matrixCompSummary.txt