Cleanup of outcommented code

[MathieuDutSik]

Pull Request Summary

Several more cleanup of the code related to the old code.

Description

Some of the changes are related to PDLIB but some to other parts of the code.

Issue(s) addressed

The issues had been discussed extensively on GitHub/discussions and the conclusion was that we should cleanup as much as possible the code.

Commit Message

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested?
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
• Have the matrix regression tests been run (if yes, please note HPC and compiler)?
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

[JessicaMeixner-NOAA]

Thanks for the additional clean-up @MathieuDutSik! I've commented on a few parts of the code to double check everyone is okay with the removal of a few items. Hopefully we'll get feedback on that in the next day or so.

[JessicaMeixner-NOAA]

Just wanted to draw attention to this line of code, just in case anyone has used this since 3.11 and there's any need to keep this around. Tagging a few others for awareness/thoughts: @ukmo-ccbunney @mickaelaccensi

[mickaelaccensi]

I don't use it

[JessicaMeixner-NOAA]

@ukmo-ccbunney are you okay with this cleanup? It looks related to SMCGRID so just wanted to double check.

[JessicaMeixner-NOAA]

Thanks for the additional clean-up work @MathieuDutSik !

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UNO_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (19 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (17 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
ww3_ta1/./work_UPD0F_U                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.17/./work_a                     (1 files differ)
ww3_tp2.17/./work_c                     (1 files differ)
ww3_tp2.17/./work_b                     (1 files differ)
ww3_tp2.6/./work_ST0                     (1 files differ)
ww3_tp2.6/./work_ST4                     (1 files differ)
ww3_tp2.6/./work_pdlib                     (1 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)

matrixCompSummary.txt
matrixDiff.txt
matrixCompFull.txt