Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync WW3 develop to dev/ufs-weather-model #987

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

Pull Request Summary

Sync WW3 develop to dev/ufs-weather-model

Description

This pulls in develop to dev/ufs-weather-model

PR of note: #985

Issue(s) addressed

Sync - no issue.

Commit Message

Sync WW3 develop to dev/ufs-weather-model

Check list

Testing

  • How were these changes tested? Tests were w/ufs-weather-model, logs below
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

RegressionTests_hera.gnu.log
RegressionTests_hera.intel.log

@MatthewMasarik-NOAA
Copy link
Collaborator

Hi @JessicaMeixner-NOAA, I'll review right now.

Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review PASS

RTs PASS
@JessicaMeixner-NOAA has posted the passing log files in the PR header for intel and gnu on hera.

Approved.

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit e026bcc into NOAA-EMC:dev/ufs-weather-model Apr 24, 2023
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the feature/syncWW30419 branch December 12, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants