The in-line post interface clean up

[WenMeng-NOAA]

Description

Dusan suggests that the in-line post interface needs a clean up for legacy setting and code format.

Solution

I'm looking at the code I thought I should mention, there are many OMP directives in which im is listed as shared variable but it is not used in the code at all, for example

!$omp parallel do default(none) private(i,j) shared(jsta,jend,im,spval,pt,pd,pint,ista,iend)
do j=jsta,jend
do i=ista,iend
pd(i,j) = spval
pint(i,j,1) = pt
end do
end do
Also, code indentation is terrible, it is very difficult to reason about the code and understand the logic with inconsistent indentation. This file (post_fv3.F90) requires some serious clean up.

Alternatives

If applicable, add a description of any alternative solutions or features you've considered.

Testing:

1. Have you tested the code changes? On what platforms?
2. Have you run regression test in ufs-weather-model or ufs-s2s-model with code changes?

• Will the baseline results change?
• If yes, please give brief explanation of your code updates on the regression test.

Dependent PRs:

Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related. Example:

• required to support noaa-emc/GFDL_atmos_cubed_sphere/issues/<issue_number>
• ncar/ccpp-physics/pull/<pr_number>
• associated ufs-weather-model/pull/<pr_number>

[WenMeng-NOAA]

@DusanJovic-NOAA Can you assign this Issue to me? I will work on it.