Update inline post

[WenMeng-NOAA]

Description

Update inline post with:

• Clean up legacy code in inline post interface

• Relocate computation of diagnostic variables

• Sync changes from offline post interface

• Update upp revision

Input data additions/changes

• No changes are expected to input data.
• Changes are expected to input data:
  • New input data.
  • Updated input data.

Anticipated changes to regression tests:

• No changes are expected to any regression test.
• Changes are expected to the following tests:
  The UPP output grib2 files for global and regional FV3, such as datasets GFSPRS, NATLEV, PRSLEV due to upp upgrade.

RegressionTests_hera.log
RegressionTests_hera-0702.log

Subcomponents involved:

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Combined with PR's (If Applicable):

Commit Queue Checklist:

• Link PR's from all sub-components involved in section below
• Confirm reviews completed in ALL sub-component PR's
• Add all appropriate labels to this PR.
• Run full RT suite on either Hera/Cheyenne AND attach log to a PR comment.: attached WCOSS2 test log
• Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

• Depends on PR: Update inline post NOAA-EMC/fv3atm#666
• Closes The in-line post interface clean up NOAA-EMC/fv3atm#645
• Closes Inline post: move computation of diagnostic variables outside a do loop that loads arrays from a bundle #1748

Testing Day Checklist:

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
• Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

• RDHPCS
  • Hera
  • Orion
  • Jet
  • Gaea
  • Cheyenne
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[jkbk2004]

@WenMeng-NOAA Can we check the status of this pr? If good status, can we follow up to attach pre regression test log?

[WenMeng-NOAA]

@WenMeng-NOAA Can we check the status of this pr? If good status, can we follow up to attach pre regression test log?

@jkbk2004 I have been waiting for my FV3 PR reviewed. Meanwhile I can sync my branch for regression testing.

[WenMeng-NOAA]

WCOSS2 RT test log
RegressionTests_wcoss2.log

[jkbk2004]

@WenMeng-NOAA All pre test looks good. Can you try to combine in @BrianCurtis-NOAA #1810 ort script update?

[WenMeng-NOAA]

@WenMeng-NOAA All pre test looks good. Can you try to combine in @BrianCurtis-NOAA #1810 ort script update?

@jkbk2004 What is the best way to combine my PR #1794 and @BrianCurtis-NOAA 's PR #1810? Manually pick up his changes and commit in my branch?

[jkbk2004]

@WenMeng-NOAA All pre test looks good. Can you try to combine in @BrianCurtis-NOAA #1810 ort script update?

@jkbk2004 What is the best way to combine my PR #1794 and @BrianCurtis-NOAA 's PR #1810? Manually pick up his changes and commit in my branch?

git clone -b upp_june https://github.com/WenMeng-NOAA/ufs-weather-model
cd ufs-weather-model/
git remote add upstream https://github.com/BrianCurtis-NOAA/ufs-weather-model
git fetch upstream
git merge upstream/fixortdbg
git push origin upp_june

[WenMeng-NOAA]

@WenMeng-NOAA All pre test looks good. Can you try to combine in @BrianCurtis-NOAA #1810 ort script update?

@jkbk2004 What is the best way to combine my PR #1794 and @BrianCurtis-NOAA 's PR #1810? Manually pick up his changes and commit in my branch?

git clone -b upp_june https://github.com/WenMeng-NOAA/ufs-weather-model cd ufs-weather-model/ git remote add upstream https://github.com/BrianCurtis-NOAA/ufs-weather-model git fetch upstream git merge upstream/fixortdbg git push origin upp_june

@jkbk2004 Done.

[FernandoAndrade-NOAA]

Ok, looks like this is ready for testing, getting started with jenkins ci @BrianCurtis-NOAA

[BrianCurtis-NOAA]

@jkbk2004 we're Hera RT's ran? Where is that log?

[jkbk2004]

@jkbk2004 we're Hera RT's ran? Where is that log?

Attached hera log in the pr description above. No crash on hera. Jenkins-ci underway. I am going to manually submit BL creation on hera now.

[jkbk2004]

@FernandoAndrade-NOAA can you check jenkins-ci status?

[FernandoAndrade-NOAA]

@FernandoAndrade-NOAA can you check jenkins-ci status?

regional_control_gnu thr and dcp failed, I'll start a manual run on Hera

[FernandoAndrade-NOAA]

Apologies for the delay, there were timeout issues with std case. dcp regional_control_gnu is still running at the moment, thr test case failed during the comparisons to NATLEV.GrbF06 and PRSLEV.GrbF06

[github-actions]

@WenMeng-NOAA please bring these up to date with respective authoritative repositories

• ufs-weather-model NOT up to date
• ww3 NOT up to date

[zach1221]

Good morning, @WenMeng-NOAA . I think we're ready to start over with our testing of this PR. Could you please sync up your branch with ufs-community:develop?

[WenMeng-NOAA]

Good morning, @WenMeng-NOAA . I think we're ready to start over with our testing of this PR. Could you please sync up your branch with ufs-community:develop?

@zach1221 Just synced.

[zach1221]

Jenkins-ci 1794 log attached. ORTs have passed.
Jenkins-ci 1794.pdf

[zach1221]

Ok, testing is complete. I'll follow up on the fv3atm sub-pr so we can begin the merging process.

[zach1221]

@WenMeng-NOAA the fv3atm sub-pr has been merged. Please update the submodule pointer and revert the change in gitmodules.
fv3atm hash: 6d17939836dd5665854a88931552f17e56c1c377

[WenMeng-NOAA]

@WenMeng-NOAA the fv3atm sub-pr has been merged. Please update the submodule pointer and revert the change in gitmodules. fv3atm hash: 6d17939836dd5665854a88931552f17e56c1c377

@zach1221 Done.