Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline post: move computation of diagnostic variables outside a do loop that loads arrays from a bundle #1748

Closed
DusanJovic-NOAA opened this issue May 10, 2023 · 2 comments · Fixed by NOAA-EMC/fv3atm#666 or #1794
Assignees

Comments

@DusanJovic-NOAA
Copy link
Collaborator

In inline post the computation of diagnostic variables here:

https://github.com/NOAA-EMC/fv3atm/blob/160b422dc1d294623cc8ebfabfbe7d28d7c65c62/io/post_fv3.F90#L4353

from line 4353 to 4413 (and several other loops) should me moved outside of the field loop (after file_loop_all loop) . Those additional fields should be computed when all the fields from the fields bundle have been assigned values, otherwise these fields will be computed when each field is assigned values.

@junwang-noaa
Copy link
Collaborator

@WenMeng-NOAA FYI.

@WenMeng-NOAA
Copy link
Contributor

@DusanJovic-NOAA @junwang-noaa Good catching. We will work on that in the upcoming PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants