Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow quilting with non-factors for layout #192

Merged
merged 3 commits into from
Nov 23, 2020
Merged

Fix to allow quilting with non-factors for layout #192

merged 3 commits into from
Nov 23, 2020

Conversation

chan-hoo
Copy link
Contributor

Description

When the layout values (lx, ly) in the input file 'input.nml' are not factors of (npx-1) and (npy-1) respectively, quilting does not work.

Issue(s) addressed

Testing

It has passed the regression test on Hera.

It makes quilting work with non-factors for layout (two cases tested):

  1. C96 conus, npx=211, npy=193, lx=4, ly=6
  2. C96 conus, npx=211, npy=193, lx=8, ly=3

@climbfuji
Copy link
Collaborator

@chan-hoo just to confirm, you are not expecting this to change the results for thee regression tests, correct?

@chan-hoo
Copy link
Contributor Author

You're correct. I think the regression tests would be set with factors for layout or quilting=false.

@climbfuji
Copy link
Collaborator

You're correct. I think the regression tests would be set with factors for layout or quilting=false.

Thanks, @chan-hoo. That's good to know. I'll pull this into release/public-v2 right away. This removes the urgency of the commit for the develop branches.

@chan-hoo chan-hoo changed the title Fix to allow quilting with non-factors for layout (#191) Fix to allow quilting with non-factors for layout Nov 3, 2020
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any of the comments that were to be removed, all good.

@junwang-noaa junwang-noaa merged commit b6957d8 into NOAA-EMC:develop Nov 23, 2020
@chan-hoo chan-hoo deleted the feature/fix_blocksize branch April 7, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants