The new CCPP suite FV3_GFS_v16b_ugwpv1 with GFSv16b (low resolution, C96_L127). #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
reviewed
Jan 21, 2021
| write (0,*) 'sum(Interstitial%dudt_mtb ) = ', sum(Interstitial%dudt_mtb ) | ||
| write (0,*) 'sum(Interstitial%dudt_ogw ) = ', sum(Interstitial%dudt_ogw ) | ||
| write (0,*) 'sum(Interstitial%dudt_tms ) = ', sum(Interstitial%dudt_tms ) | ||
| ! CIRES UGWP v0 VAY-2020 does not make any sense to print SUM |
There was a problem hiding this comment.
I disagree. This is useful to detect b4b differences between runs etc.
|
If you consider it to be important you can keep it, I don't know how to use
the total sum as diagnostics.
…On Thu, Jan 21, 2021 at 4:40 PM Dom Heinzeller ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In gfsphysics/GFS_layer/GFS_typedefs.F90
<#227 (comment)>:
> -! CIRES UGWP v0
- write (0,*) 'sum(Interstitial%gw_dudt ) = ', sum(Interstitial%gw_dudt )
- write (0,*) 'sum(Interstitial%gw_dvdt ) = ', sum(Interstitial%gw_dvdt )
- write (0,*) 'sum(Interstitial%gw_dtdt ) = ', sum(Interstitial%gw_dtdt )
- write (0,*) 'sum(Interstitial%gw_kdis ) = ', sum(Interstitial%gw_kdis )
- write (0,*) 'sum(Interstitial%tau_mtb ) = ', sum(Interstitial%tau_mtb )
- write (0,*) 'sum(Interstitial%tau_ogw ) = ', sum(Interstitial%tau_ogw )
- write (0,*) 'sum(Interstitial%tau_tofd ) = ', sum(Interstitial%tau_tofd )
- write (0,*) 'sum(Interstitial%tau_ngw ) = ', sum(Interstitial%tau_ngw )
- write (0,*) 'sum(Interstitial%zmtb ) = ', sum(Interstitial%zmtb )
- write (0,*) 'sum(Interstitial%zlwb ) = ', sum(Interstitial%zlwb )
- write (0,*) 'sum(Interstitial%zogw ) = ', sum(Interstitial%zogw )
- write (0,*) 'sum(Interstitial%dudt_mtb ) = ', sum(Interstitial%dudt_mtb )
- write (0,*) 'sum(Interstitial%dudt_ogw ) = ', sum(Interstitial%dudt_ogw )
- write (0,*) 'sum(Interstitial%dudt_tms ) = ', sum(Interstitial%dudt_tms )
+! CIRES UGWP v0 VAY-2020 does not make any sense to print SUM
I disagree. This is useful to detect b4b differences between runs etc.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#227 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOVBSB435MXOYYMAQK3SFPDS3C3MXANCNFSM4V5JHFLA>
.
|
|
Also
write (0,*) 'sum(Interstitial%gw_dudt ) = ',
sum(Interstitial%gw_dudt )
- write (0,*) 'sum(Interstitial%gw_dvdt ) = ',
sum(Interstitial%gw_dvdt )
- write (0,*) 'sum(Interstitial%gw_dtdt ) = ',
sum(Interstitial%gw_dtdt )
- write (0,*) 'sum(Interstitial%gw_kdis ) = ',
sum(Interstitial%gw_kdis
in my branch some variables, like above, are removed from
"typedefs.F90 and meta'
On Thu, Jan 21, 2021 at 5:55 PM Valery Yudin - NOAA Affiliate <
valery.yudin@noaa.gov> wrote:
… If you consider it to be important you can keep it, I don't know how to
use the total sum as diagnostics.
On Thu, Jan 21, 2021 at 4:40 PM Dom Heinzeller ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In gfsphysics/GFS_layer/GFS_typedefs.F90
> <#227 (comment)>:
>
> > -! CIRES UGWP v0
> - write (0,*) 'sum(Interstitial%gw_dudt ) = ', sum(Interstitial%gw_dudt )
> - write (0,*) 'sum(Interstitial%gw_dvdt ) = ', sum(Interstitial%gw_dvdt )
> - write (0,*) 'sum(Interstitial%gw_dtdt ) = ', sum(Interstitial%gw_dtdt )
> - write (0,*) 'sum(Interstitial%gw_kdis ) = ', sum(Interstitial%gw_kdis )
> - write (0,*) 'sum(Interstitial%tau_mtb ) = ', sum(Interstitial%tau_mtb )
> - write (0,*) 'sum(Interstitial%tau_ogw ) = ', sum(Interstitial%tau_ogw )
> - write (0,*) 'sum(Interstitial%tau_tofd ) = ', sum(Interstitial%tau_tofd )
> - write (0,*) 'sum(Interstitial%tau_ngw ) = ', sum(Interstitial%tau_ngw )
> - write (0,*) 'sum(Interstitial%zmtb ) = ', sum(Interstitial%zmtb )
> - write (0,*) 'sum(Interstitial%zlwb ) = ', sum(Interstitial%zlwb )
> - write (0,*) 'sum(Interstitial%zogw ) = ', sum(Interstitial%zogw )
> - write (0,*) 'sum(Interstitial%dudt_mtb ) = ', sum(Interstitial%dudt_mtb )
> - write (0,*) 'sum(Interstitial%dudt_ogw ) = ', sum(Interstitial%dudt_ogw )
> - write (0,*) 'sum(Interstitial%dudt_tms ) = ', sum(Interstitial%dudt_tms )
> +! CIRES UGWP v0 VAY-2020 does not make any sense to print SUM
>
> I disagree. This is useful to detect b4b differences between runs etc.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#227 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AOVBSB435MXOYYMAQK3SFPDS3C3MXANCNFSM4V5JHFLA>
> .
>
|
Merged
|
Merged as part of #241. |
LarissaReames-NOAA
pushed a commit
to LarissaReames-NOAA/fv3atm
that referenced
this pull request
Nov 17, 2023
* Performance optimization of moving nest. * Moving nest performance optimization stage 2. * Update atmos_model_nml in driver/fvGFS/atmosphere.F90 so that it is consistent with that in FV3/atmos_model.F90. * Adding upoff as a namelist parameter * Moving nest code cleanup: modularization phase. * Ported from fms_io to fms2_io. Also removed debug print statements. * Restructuring moving_nest code from atmos_cubed_sphere to FV3 level. * Added namelist flag fv_timings to enable detailed performance timings; defaults to false. Co-authored-by: Bin Liu <Bin.Liu@noaa.gov> Co-authored-by: Biju Thomas <biju.thomas@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new CCPP suite FV3_GFS_v16b_ugwpv1 and regression tests for warm_start and cold_starts
with GFSv16b (low resolution, C96_L127). The new suite represents the upgrade of uGWP (V1),CU-CIRES. It is capable to reproduce the realistic FV3GFS climate, including equatorial dynamics (QBO and SAO, 20-60 km)) and annual cycles in the extra-tropics and polar regions in the upper atmsosphere (20-80km). It can be executed and tested with the gsldrag sub-grid scale orography physics of gsl/develop for UFS-R2O planned activity in 2021.
Issue(s) addressed
issues to be closed with this PR in repositories : ufs-weather-model #347 issue
fv3atm #222 issue
ccpp-physics #542 issue
Testing
How were these changes tested? answer: hera
What compilers / HPCs was it tested with? answer: intel
Are the changes covered by regression tests? answer: yes (new baseline for UFS-127L-C96 see ufsw-weather-model/tests)
Have the ufs-weather-model regression test been run? answer: hera-intel
rt.gsd_ugwpv1_1c.log:+ NEW_BASELINE=/scratch1/NCEPDEV/stmp4/Valery.Yudin/FV3_RT/REGRESSION_TEST_GSL_DEVELOP_INTEL
create mode 100644 tests/rt.gsd_ugwpv1.1m.log
create mode 100644 tests/rt.gsd_ugwpv1_1c.log
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
https://github.com/ValeryYudin-NOAA/ccpp-physics/tree/master
https://github.com/ValeryYudin-NOAA/ufs-weather-model/develop
Those branches should have matching names (ideally): first PR
Do PRs in upstream repositories need to be merged first?
first https://github.com/ValeryYudin-NOAA/ccpp-physics/tree/master