Hotfix for RRTMGP using multiple threads #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DusanJovic-NOAA
requested review from
climbfuji,
junwang-noaa and
yangfanglin
|
Please add Qinfu Liu as a reviewer |
junwang-noaa
approved these changes
Feb 23, 2021
|
Dusan,
Thank you very much. I will start reviewing the code changes.
Qingfu
…On Tue, Feb 23, 2021 at 1:04 PM Dusan Jovic ***@***.***> wrote:
@DusanJovic-NOAA <https://github.com/DusanJovic-NOAA> requested your
review on: #247 <#247> Hotfix for
RRTMGP using multiple threads.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#247 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGTS6UQZEBFM3F7BVYW3M53TAPUZLANCNFSM4XW7NPHA>
.
|
Qingfu-Liu
approved these changes
Feb 24, 2021
DusanJovic-NOAA
approved these changes
Feb 24, 2021
climbfuji
approved these changes
Feb 24, 2021
| @@ -6438,6 +6437,14 @@ subroutine interstitial_create (Interstitial, IM, Model) | |||
| allocate (Interstitial%toa_src_sw (IM,Model%rrtmgp_nGptsSW)) | |||
| allocate (Interstitial%toa_src_lw (IM,Model%rrtmgp_nGptsLW)) | |||
| allocate (Interstitial%active_gases_array (Model%nGases)) | |||
| ! ty_gas_concs | |||
There was a problem hiding this comment.
Obviously %ncol and %nlay are fixed throughout the run.
What about gas_name, concs, conc? Do they depend on each grid, and if yes, do they need to be persistent? If not, then we should add them to the %rad_reset calls for the DDT (for clarity) - in the next PR. If they need to be persistent, they need to be moved to radtend or something like that (also in the next PR).
There was a problem hiding this comment.
@climbfuji
I set the ncol and nlay here once in the DDT, type-bound procedures rely on it later.
gas_concentrations(ty_gas_concs) should be added to rad_reset. I will make sure to include this in my next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several changes to the initialization and setup of the RRTMGP radiation scheme to allow for use across multiple openMP threads.
*) Moved Interstitial RRTMGP DDTs (ty_rrtmgp_gas_optics, ty_cloud_optics) to static fields defined during initialization in module memory.
*) Add "$omp critical" statements around the calling type-bound procedures during initialization.
*) Move allocation of ty_gas_conc from Interstitial to GFS_typedefs. Initialize ty_gas_concs for all blocks during initialization.
This issue was brought to our attention by @yangfanglin and Qingfu Liu at EMC while testing RRTMGP in high-resolution cases, which require multiple threads.
The GP regression tests on hera using Intel were successful.
There are no changes to the baselines
Waiting on NCAR/ccpp-physics#568