Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use assumed-size arrays in CCPP, Fortran/metadata consistency fixes in CCPP #284

Merged
merged 49 commits into from
Apr 30, 2021
Merged

Use assumed-size arrays in CCPP, Fortran/metadata consistency fixes in CCPP #284

merged 49 commits into from
Apr 30, 2021

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Apr 15, 2021 •
edited
Loading

Description

This PR removes one entry from the ccpp_prebuild_config.py that is no longer required, and updates the submodule pointer for ccpp-physics for the changes described in NCAR/ccpp-physics#611.

Also included:

  • workaround to propagate REPRO/Bitforbit mode correctly to CCPP - will be cleaned up in @DusanJovic-NOAA's next PR
  • tiny bugfix for aux3d arrays (active attribute in CCPP metadata was wrong), no impact on any of the tests, this is just a debugging feature

Issue(s) addressed

none in fv3atm

Testing

See ufs-community/ufs-weather-model#527

Dependencies

NCAR/ccpp-physics#611
#284
ufs-community/ufs-weather-model#527

dustinswales and others added 30 commits February 15, 2021 17:46
@dustinswales
Initial commit
164d443
@dustinswales
Define interstitial for minimum temperature allowed by GP.
e15f970
@dustinswales
Added MPI to RRTMGP initialization.
8178094
@dustinswales
Initial commit
8346e38
@dustinswales
Bug fixes for l127 configuration using RRTMGP
080af1c
@dustinswales
Initial commit
663376a
@dustinswales
Merge remote-tracking branch 'upstream/hotfix_tlay_for_c768l127' into…
e5cff7d 
… addLWadj_fullProfile
@dustinswales
Full profile LW flux adjustment using RRTMGP Jacobians.
60afd3c
@dustinswales
LW Jacobian adjustment on full profule working.
04053dd
@dustinswales
Merge remote-tracking branch 'upstream/add_RRFS_to_GP' into addLWadj_…
08add50 
…fullProfile
@dustinswales
Updated SDFs. Cleanup old piece of code from merge.
61a24b6
@dustinswales
Added adjustment with Jacobian to surface flux, used for coupling.
4ccf5a5
@dustinswales
Pass cloud-fraction through GP-2-mpinterfaces when using SGS clouds. …
d7faec1 
…Added updated heating-rate to coupling type.
@dustinswales
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into add…
c424b50 
…LWadj_fullProfile
@dustinswales
Updated physics/rte-rrtmgp hash
e7fb1d2
@climbfuji
Remove unnecessary build configuration in ccpp/CMakeLists.txt
c8ceb79
@dustinswales
Merge pull request #5 from climbfuji/rrtmgp_noopenmp_dom
7414e01 
RRTMGP w/o OpenMP
@dustinswales
Updated physics w openmp removed from rte-rrtmgp
8f4b13b
@dustinswales
Merge branch 'addLWadj_fullProfile' of https://github.com/dustinswale…
e435412 
…s/fv3atm into addLWadj_fullProfile
@dustinswales
Moved allocation of LW interstitials to GFS_typedefs. Removed downwar…
cf6f890 
…d LW Jacobian from RRTMGP flux adjustement.
@dustinswales
Updated my physics
47f3ec0
@dustinswales
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into add…
b963221 
…LWadj_fullProfile
@dustinswales
Moved assignment of spectral information from _init()'s to _run() for…
9bac131 
… RRTMGP.
@dustinswales
Bugfixes for GP/ThompsonMP coupling
507c579
@dustinswales
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into HEAD
e19188a
@dustinswales
Updated .gitmodules
eebd2a6
@dustinswales
Fix conflict bug from previous merge.
f3eea3c
@climbfuji
Update .gitmodules, submodule pointer for ccpp-physics, and ccpp/conf…
26012a7 
…ig/ccpp_prebuild_config.py
@climbfuji
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into cap…
959c411 
…gen_fixes_assumed_sizes
@climbfuji
Update submodule pointer for ccpp-physics
aa237f8
This was referenced Apr 22, 2021
Merged
Merged
@climbfuji climbfuji marked this pull request as ready for review April 22, 2021 22:50
@climbfuji climbfuji changed the title WORK IN PROGRESS: use assumed-size arrays in CCPP, Fortran/metadata consistency fixes in CCPP Use assumed-size arrays in CCPP, Fortran/metadata consistency fixes in CCPP Apr 23, 2021
@climbfuji climbfuji force-pushed the capgen_fixes_assumed_sizes branch from 13a64c9 to 788cb5d Compare April 28, 2021 20:19
@climbfuji climbfuji requested a review from llpcarson April 30, 2021 12:05
@climbfuji
Copy link
Collaborator Author

ccpp-physics hash is updated. Ready to merge.

@DusanJovic-NOAA DusanJovic-NOAA merged commit ce81602 into NOAA-EMC:develop Apr 30, 2021
LarissaReames-NOAA pushed a commit to LarissaReames-NOAA/fv3atm that referenced this pull request Nov 17, 2023
@laurenchilutti
tools/fv_io: add missing else statement and ensures all _is_open vari…
bceee88 
…ables to .false. when files are closed (NOAA-EMC#284)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@llpcarson llpcarson Awaiting requested review from llpcarson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@climbfuji @junwang-noaa @DusanJovic-NOAA @dustinswales