-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional scaling to RRTMGP flux adjustment #319
Closed
dustinswales
wants to merge
10
commits into
NOAA-EMC:develop
from
dustinswales:hotfix_AddPLimitToLWJacAdj
Closed
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
df7028b
Added more safeguards against out-of-bounds temperature to GP inputs.…
dustinswales 971dd90
Updated physics.
dustinswales 86c3050
Add vetical decay to impact of flux adjustment above threshold.
dustinswales dca609d
Added logistic function to damp the LW flux adjustment with height
dustinswales c323a06
Reorganized RRTMGP aerosol optics.
dustinswales 338f6ad
Reverted previous changes to ccpp-physics
dustinswales ebf76e3
Revert "Reorganized RRTMGP aerosol optics."
dustinswales 58d269c
Bug fix. Add transition to HR adjustment.
dustinswales 3fbb0ab
Omission from previous revert.
dustinswales 295c53c
Cleanup for PR review
dustinswales File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now this is pretty confusing ... why can't
lfnc_k
be defined such thatModel%lfnc_k = lfnc_k
? And would a default value of1.0/-999.0=-0.001...
still be correct (I assume unused if< 0
?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're spot on. I just cleaned this up