inline post restart issue with gnu compiler #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
climbfuji
requested changes
Jun 1, 2021
io/post_gfs.F90
Outdated
| @@ -156,11 +156,13 @@ subroutine post_run_gfs(wrt_int_state,mypei,mpicomp,lead_write, & | |||
| if(mype==0) print *,'af read_xml at fh00,name=',trim(filenameflat) | |||
| else if(ifhr > 0) then | |||
| filenameflat = 'postxconfig-NT.txt' | |||
| if(size(paramset)>0) then | |||
| if(associated(paramset) .and. size(paramset)>0) then | |||
There was a problem hiding this comment.
The Fortran compiler specifications do not state that the tests in an if clause will be executed ini the order written. You need to do the following to be fully compliant:
if (associated(paramset)) then
if (size(paramset)>0) then
There was a problem hiding this comment.
Actually the size(paramset) is 1 but associated(paramset) is false with gnu compiler.
io/post_regional.F90
Outdated
| @@ -160,11 +160,13 @@ subroutine post_run_regional(wrt_int_state,mypei,mpicomp,lead_write, & | |||
| if(mype==0) print *,'af read_xml at fh00,name=',trim(filenameflat) | |||
| else if(ifhr > 0) then | |||
| filenameflat = 'postxconfig-NT.txt' | |||
| if(size(paramset)>0) then | |||
| if(associated(paramset) .and. size(paramset)>0) then | |||
There was a problem hiding this comment.
How? If associated(paramset) (means it's a pointer) is false, how can the size be 1?
There was a problem hiding this comment.
That is what I got when I tried with gnu compiler. The issue happened when it tried to get the size of paramset(1)%param.
…
I think it would be best to make the same changes as in lines 161-162, 165-166.
DusanJovic-NOAA
approved these changes
Jun 1, 2021
|
That is what I got when I tried with gnu compiler. The issue happened when
it tried to get the size of paramset(1)%param.
…On Tue, Jun 1, 2021 at 1:12 PM Dom Heinzeller ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In io/post_regional.F90
<#321 (comment)>:
> @@ -160,11 +160,13 @@ subroutine post_run_regional(wrt_int_state,mypei,mpicomp,lead_write, &
if(mype==0) print *,'af read_xml at fh00,name=',trim(filenameflat)
else if(ifhr > 0) then
filenameflat = 'postxconfig-NT.txt'
- if(size(paramset)>0) then
+ if(associated(paramset) .and. size(paramset)>0) then
How? If associated(paramset) (means it's a pointer) is false, how can the
size be 1?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#321 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TPGKGXOVDWYMES7AETTQUIHJANCNFSM45XB5XNQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to fix the issue with inline post in restart runs with gnu compiler.
Is a change of answers expected from this PR? The fix does not changes results.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
Run the control restart test with gnu compiler
What compilers / HPCs was it tested with? GNU
Are the changes covered by regression tests?
NO, the current control restart does not have inline post. The global tests update (ufs-weather-model PR#561) has inline post turned on in the control and restart.
Have the ufs-weather-model regression test been run? On what platform?
Tested on hera. Will test on other tier-1 platforms
Will the code updates change regression test baseline?
This change does not change results, but the ufs-weather-model PR#561 does require new baseline.
Please commit the regression test log files in your ufs-weather-model branch
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs