-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update several units in CCPP metadata following CCPP framework update #422
Merged
DusanJovic-NOAA
merged 9 commits into
NOAA-EMC:develop
from
climbfuji:correct_units_due_to_feature_capgen
Nov 23, 2021
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
596e23b
Update .gitmodules and submodule pointers for ccpp-framework and ccpp…
climbfuji 178e777
Replace units 'various' with 'mixed', update several invalid units of…
climbfuji af17924
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into cor…
climbfuji 9229956
Update submodule pointers for ccpp-framework and ccpp-physics
climbfuji 6f74ce7
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into cor…
climbfuji 4b60718
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into cor…
climbfuji e57adb3
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into cor…
climbfuji 0ed5b4d
Change units of relative humidity variables in CCPP metadata from 1 o…
climbfuji 153516b
Revert change to .gitmodules and update submodule pointers for ccpp-f…
climbfuji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule framework
updated
78 files
Submodule physics
updated
36 files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask what is the meaning of "units 1" and "units mixed"? Maybe you can see the units in NCEP grib2 product table as a reference? https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-2-0-1.shtml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relative humidity in the code is expressed between 0 and 1, i.e. as a fraction. If it was a real percentage, it would range from 0 to 100. See the actual code in ccpp-physics.
Note also we do have
percentas a valid unit for such quantities. The%symbol is not acceptable as a unit in the CCPP, it causes all sorts of problem with parsing code (also because members of derived data types have a percent in the name, e.g.foo%bar). We could usefractioninstead of1for relative humidity, but if so we need to go back to the CCPP framework developers and have them confirm.Any variable that is a number without a physical unit can have unit
1.mixedis simply replacingvariousand is used in cases where a variable contains multiple units. For example, the grab-bag tracer arrayqgrscontains mass mixing ratios (kg kg-1), number concentrations(kg-1), cloud amount (fractionor1, can't remember) etc. When the individual members of theqgrsarray are passed, then the correct units can be used. But when the entire array is passed, we need to usemixed(wasvariousuntil now).Lastly, note that CCPP units do not follow the standard in https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-2-0-1.shtml. If they do match, that is great, and we should strive for consistency where possible. But CCPP units follow CF conventions and
udunits, with the extensions defined in https://github.com/ESCOMP/CCPPStandardNames/blob/main/StandardNamesRules.rst (as approved by the CCPP framework developer team).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing the grib2 doc with what we have I see a nearly 100% match. The only difference is that we use
percentinstead of%for real percentages. Some units may differ from scheme to scheme (e.g. Thompson MP defines cloud effective radii in micron), but this is why we have automatic unit conversions - this way the host models can keep their units and still use the physics as-is.