Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use optional chunksizes argument in register_restart_field calls #595

Merged
merged 35 commits into from
Aug 31, 2023

Conversation

DusanJovic-NOAA
Copy link
Collaborator

Description

This PR updates the register_restart_field calls to pass optional argument 'chunksizes'. Chunk sizes are equal to the corresponding dimension size. This change will speed up reading the restart in RRFS DA.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Sam's PR (starting 8/21) will bring in CLM changes that will change things a little, but these code changes look OK.

@zach1221
Copy link
Collaborator

zach1221 commented Aug 31, 2023

@DusanJovic-NOAA cubed sphere PR NOAA-GFDL/GFDL_atmos_cubed_sphere#223 has been merged. Please updated submodule pointer and revert gitmodule url.
cubed sphere hash : 52bf918

@zach1221
Copy link
Collaborator

@jkbk2004 This PR is ready to merge.

@jkbk2004 jkbk2004 merged commit d9525db into NOAA-EMC:develop Aug 31, 2023
@DusanJovic-NOAA DusanJovic-NOAA deleted the restart_chunksizes branch August 31, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using fms chunksize and compression options in dycore
5 participants