Bug fix for the NoahMP scheme #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 16, 2022
jkbk2004
requested review from
DusanJovic-NOAA,
BrianCurtis-NOAA and
jkbk2004
DusanJovic-NOAA
approved these changes
Nov 29, 2022
|
@jkbk2004 ccpp-physics#23 was merged. I will revert the pointer and update hash. |
|
@ChunxiZhang-NOAA sure! we can merge in with update ccpp pointer and reverting gitmodules branch. |
|
@jkbk2004 Done. |
jkbk2004
approved these changes
Nov 29, 2022
BrianCurtis-NOAA
approved these changes
Nov 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the ccpp-physics bugs that are reported in #963 and #964. It will change the baselines for the RTs that use the NoahMP scheme.
Issue(s) addressed
Testing
The testing will be reported in the upstream ufs-weather-model PR.
Dependencies