Create ESMF field attributes using the same kind as field data values #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
|
Code change only on fv_nggps_diag.f90 at the cubed sphere fvGFS driver level. The dependency NOAA-GFDL/GFDL_atmos_cubed_sphere#236 was approved. We can go ahead to review and approve for the pr. Downstream ufs-wm regression tests are running well ufs-community/ufs-weather-model#1566. |
|
@DusanJovic-NOAA are ESMF field attributes in r4 to keep computational costs at a minimum? I hate the inconsistency of going between r8 and r4 because it can cause issues in the future, and would like to see all be r4 or all be r8 to cause less issues moving forward. |
junwang-noaa
approved these changes
Jan 24, 2023
ESMF attributes must be the same kind as field data, which for the history files is always real(4). |
BrianCurtis-NOAA
approved these changes
Jan 24, 2023
BinLiu-NOAA
pushed a commit
to hafs-community/fv3atm
that referenced
this pull request
Mar 20, 2023
…NOAA-EMC#618) * Use 32bit value for 'missing_value' and '_FillValue' attributes
jkbk2004
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Moving nest performance optimization stage 2. * update atmos_model and FV3GFS_io read performance when io_layout=1,1 and allow one to override data integrity checks in FMS restart logic * Add the following HAFS ccpp physics suites (@ChunxiZhang-NOAA and @BinLiu-NOAA): suite_FV3_HAFS_v0_thompson.xml suite_FV3_HAFS_v0_thompson_nonsst.xml suite_FV3_HAFS_v0_thompson_noahmp.xml suite_FV3_HAFS_v0_thompson_noahmp_nonsst.xml * Update submodule upp, which has the fix for regional latlon grid crossing the prime meridian. * Only call atmosphere_fill_nest_cpl at the cap driver time steps (coupling time steps). This is to reduce the overhead introduced by downscaling the coupling variables from FV3ATM parent to nest. * Removed reference to unused variable parent_x. * Update to point submodule ccpp/physics to the feature/hafsv0.3_final branch of the hafs-community fork. * FV3-related typedefs changes for the Hurricane PBL options * Update submodule ccpp/physics, which added the tc_pbl option in the GFS sa-TKE EDMF PBL scheme for HAFS/hurricane modeling. * Update to point the support/HAFS branch for upp, ccpp-physics and atmos_cubed_sphere. * Adding upoff as a namelist parameter * Update submodule atmos_cubed_sphere, which has updated the time string in internal tracker output (fort.602, phtcf file). * fix initialization issue for moving nest grid in debug mode (#622) * Update submodule atmos_cubed_sphere to point the production/hafs.v1 branch. * Update submodule upp, which cherry-picked the wind GUST fix from the develop branch. * Create ESMF field attributes using the same kind as field data values (#618) * Use 32bit value for 'missing_value' and '_FillValue' attributes * Update ccpp/suites_not_used/suite_FV3_HAFS_v1* files, needed for the latest sync. * Update submodule UPP to point to the feature/hafsv2_baseline branch. * Add a namelist to include ocean current in the computation of air-sea fluxes. * Change the variable name for zonal ocean current from ssu to usfco. * Change the variable name for meridional ocean current from ssv to vsfco. * Update HAFS thompson ccpp suites and move suite_FV3_HAFS_v1_thompson.xml and suite_FV3_HAFS_v1_thompson_nonsst.xml under ccpp/suites since they are used by operational HAFS configurations. * Update usfco and vsfco standard and long names in GFS_typedefs.meta. * Update standard name for icplocn2atm in ccpp/data/GFS_typedefs.meta. --------- Co-authored-by: Bin.Liu <Bin.Liu@noaa.gov> Co-authored-by: William Ramstrom <William.Ramstrom@noaa.gov> Co-authored-by: Rusty.Benson <rusty.benson@noaa.gov> Co-authored-by: AndrewHazelton <andrew.hazelton@noaa.gov> Co-authored-by: Biju Thomas <biju.thomas@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
add_field_to_phybundlesubroutine in io/FV3GFS_io.F90. The values used for esmf field attributes (_FillValueandmissing_value) must be the same real kind as the field data values, in this case REAL(4) in order to avoid type mismatch checks in PIO library which is used by ESMF I/O module.Issue(s) addressed
ufs-community/ufs-weather-model#1564
Testing
How were these changes tested? Yes
What compilers / HPCs was it tested with? Intel/Hera
Are the changes covered by regression tests? Yes
Have the ufs-weather-model regression test been run? On what platform?
Dependencies