release/public-v1: bug fix for threading issue in stochastic physics #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2020
DusanJovic-NOAA
approved these changes
Feb 10, 2020
|
I will be running the tests later tonight, just updated the codebase following the merge of ufs-community/ufs-weather-model#54 and NOAA-PSL/stochastic_physics#13. |
junwang-noaa
approved these changes
Feb 11, 2020
|
Dom, So after your RT is done, we will make the commit. |
This was referenced Feb 28, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stochastic physics code hangs indefinitely when called with more than two threads. This PR and associated PRs below fix/avoid this issue by
See issue ufs-community/ufs-weather-model#51
Since these changes do not affect the physics or the regression test results (these are created with stochastic physics turned off), the PRs listed below can be merged anytime after the code review.
Associated PRs:
ufs-community/ufs-weather-model#55
#62
NOAA-PSL/stochastic_physics#13