Combo for ccpp/physics #41 and #45 and ccpp/framework submodule pointer update for #462 #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensemble perturbationsons
Allow HAFS app to be compiled with 64bit FMS (NOAA-EMC#626)
…gitmodules to to Grant's combo ccpp/physics branch
grantfirl
changed the title
37 tasks
|
This replaces #632 and is ready for review. |
DusanJovic-NOAA
approved these changes
Mar 14, 2023
jkbk2004
approved these changes
Mar 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR combines 2 ccpp/physics PRs and 1 ccpp/framework PR.
ccpp/physics PR41: changes CMakeLists.txt to depend on the SP library. This is required for JEDI: JCSDA/ufs-bundle#19
ccpp/physics PR45: exposes 3 NSSL MP parameters to the physics namelist
ccpp/framework PR462: addresses an error message bug in the unit conversion part of ccpp_prebuild
No answer changes are expected for any of these changes.
Issue(s) addressed
Testing
See ufs-community/ufs-weather-model#1654 for testing information
Dependencies