Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name change for two NSSL MP namelist parameters #662

Merged
merged 8 commits into from
Jul 5, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@
branch = main
[submodule "ccpp/physics"]
path = ccpp/physics
url = https://github.com/ufs-community/ccpp-physics
branch = ufs/dev
# url = https://github.com/ufs-community/ccpp-physics
# branch = ufs/dev
url = https://github.com/MicroTed/ccpp-physics.git
branch = ufs-dev-tm
[submodule "upp"]
path = upp
url = https://github.com/NOAA-EMC/UPP
Expand Down
20 changes: 10 additions & 10 deletions ccpp/data/GFS_typedefs.F90
Original file line number Diff line number Diff line change
Expand Up @@ -970,9 +970,9 @@ module GFS_typedefs
real(kind=kind_phys) :: nssl_cccn !< CCN concentration (m-3)
real(kind=kind_phys) :: nssl_alphah !< graupel shape parameter
real(kind=kind_phys) :: nssl_alphahl !< hail shape parameter
real(kind=kind_phys) :: nssl_alphar ! shape parameter for rain (imurain=1 only)
real(kind=kind_phys) :: nssl_ehw0_in ! constant or max assumed graupel-droplet collection efficiency
real(kind=kind_phys) :: nssl_ehlw0_in! constant or max assumed hail-droplet collection efficiency
real(kind=kind_phys) :: nssl_alphar ! shape parameter for rain (imurain=1 only)
real(kind=kind_phys) :: nssl_ehw0 ! constant or max assumed graupel-droplet collection efficiency
real(kind=kind_phys) :: nssl_ehlw0 ! constant or max assumed hail-droplet collection efficiency
logical :: nssl_hail_on !< NSSL flag to activate the hail category
logical :: nssl_ccn_on !< NSSL flag to activate the CCN category
logical :: nssl_invertccn !< NSSL flag to treat CCN as activated (true) or unactivated (false)
Expand Down Expand Up @@ -3416,8 +3416,8 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, master, &
real(kind=kind_phys) :: nssl_alphah = 0.0 !< graupel shape parameter
real(kind=kind_phys) :: nssl_alphahl = 1.0 !< hail shape parameter
real(kind=kind_phys) :: nssl_alphar = 0.0 ! shape parameter for rain (imurain=1 only)
real(kind=kind_phys) :: nssl_ehw0_in = 0.9 ! constant or max assumed graupel-droplet collection efficiency
real(kind=kind_phys) :: nssl_ehlw0_in = 0.9 ! constant or max assumed hail-droplet collection efficiency
real(kind=kind_phys) :: nssl_ehw0 = 0.9 ! constant or max assumed graupel-droplet collection efficiency
real(kind=kind_phys) :: nssl_ehlw0 = 0.9 ! constant or max assumed hail-droplet collection efficiency
logical :: nssl_hail_on = .false. !< NSSL flag to activate the hail category
logical :: nssl_ccn_on = .true. !< NSSL flag to activate the CCN category
logical :: nssl_invertccn = .true. !< NSSL flag to treat CCN as activated (true) or unactivated (false)
Expand Down Expand Up @@ -3879,7 +3879,7 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, master, &
ext_diag_thompson, dt_inner, lgfdlmprad, &
sedi_semi, decfl, &
nssl_cccn, nssl_alphah, nssl_alphahl, &
nssl_alphar, nssl_ehw0_in, nssl_ehlw0_in, &
nssl_alphar, nssl_ehw0, nssl_ehlw0, &
nssl_invertccn, nssl_hail_on, nssl_ccn_on, &
!--- max hourly
avg_max_length, &
Expand Down Expand Up @@ -4471,8 +4471,8 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, master, &
Model%nssl_alphah = nssl_alphah
Model%nssl_alphahl = nssl_alphahl
Model%nssl_alphar = nssl_alphar
Model%nssl_ehw0_in = nssl_ehw0_in
Model%nssl_ehlw0_in = nssl_ehlw0_in
Model%nssl_ehw0 = nssl_ehw0
Model%nssl_ehlw0 = nssl_ehlw0
Model%nssl_hail_on = nssl_hail_on
Model%nssl_ccn_on = nssl_ccn_on
Model%nssl_invertccn = nssl_invertccn
Expand Down Expand Up @@ -6411,8 +6411,8 @@ subroutine control_print(Model)
print *, ' nssl_alphah - graupel shape parameter : ', Model%nssl_alphah
print *, ' nssl_alphahl - hail shape parameter : ', Model%nssl_alphahl
print *, ' nssl_alphar - rain shape parameter : ', Model%nssl_alphar
print *, ' nssl_ehw0_in - graupel-droplet collection effiency : ', Model%nssl_ehw0_in
print *, ' nssl_ehlw0_in - hail-droplet collection effiency : ', Model%nssl_ehlw0_in
print *, ' nssl_ehw0 - graupel-droplet collection effiency : ', Model%nssl_ehw0
print *, ' nssl_ehlw0 - hail-droplet collection effiency : ', Model%nssl_ehlw0
print *, ' nssl_hail_on - hail activation flag : ', Model%nssl_hail_on
print *, ' lradar - radar refl. flag : ', Model%lradar
print *, ' lrefres : ', Model%lrefres
Expand Down
4 changes: 2 additions & 2 deletions ccpp/data/GFS_typedefs.meta
Original file line number Diff line number Diff line change
Expand Up @@ -4322,14 +4322,14 @@
dimensions = ()
type = real
kind = kind_phys
[nssl_ehw0_in]
[nssl_ehw0]
standard_name = nssl_graupel_collection_efficiency
long_name = graupel droplet collection efficiency in NSSL microphysics scheme
units = none
dimensions = ()
type = real
kind = kind_phys
[nssl_ehlw0_in]
[nssl_ehlw0]
standard_name = nssl_hail_collection_efficiency
long_name = hail droplet collection efficiency in NSSL microphysics scheme
units = none
Expand Down