Fixed stratosphere warm bias and code optimization for MERRA2 #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
|
@grantfirl we may begin working UFS-WM PR #1815 today, would you be able to resolve the conflicts here ? |
|
@zach1221 This is ready for final review/merge. |
|
Thanks, @grantfirl ! Sending reviews. |
BrianCurtis-NOAA
approved these changes
Jul 24, 2023
jkbk2004
approved these changes
Jul 24, 2023
|
Alright, @BrianCurtis-NOAA . We have our approvals. Can you please merge this PR? |
|
@BrianCurtis-NOAA Hold on a sec. I messed up .gitmodules. |
|
@BrianCurtis-NOAA Sorry about that. All good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening on behalf of @AnningCheng-NOAA. This replaces the accidentally closed #664.
This and the changes in ccpp/physics fix the stratosphere warm bias for the merra2_thompson test
These changes are expected to change baselines for the following tests:
atmaero_control_p8_rad_micro
merra2_thompson
Issue(s) addressed
ufs-community/ufs-weather-model#1786
Testing
Testing was done by @AnningCheng-NOAA using UFS RTs on Hera/Intel only. Baselines will change for:
atmaero_control_p8_rad_micro
merra2_thompson
Logs will be attached in the ufs-weather-model PR.
Dependencies
ufs-community/ccpp-physics#88