Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed excessive evaporation when both innerloop=T and mraerosol=T #816

Merged
merged 8 commits into from
May 1, 2024

Conversation

AnningCheng-NOAA
Copy link
Contributor

@AnningCheng-NOAA AnningCheng-NOAA commented Apr 1, 2024

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
When turning on Inner loop and setting mraerosol=T, too much evaporation from aerosol below the cloud layer causing global mean liquid water decreasing nearly 40 g/m^2. turning off evaporation from NWFA, but turning on the evaporation without aerosol influence.
Is a change of answers expected from this PR?
Yes. new baselines for
atmaero_control_p8_rad_micro_intel
merra2_thompson_intel

Issue(s) addressed

ufs-community/ufs-weather-model#2219

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@DusanJovic-NOAA DusanJovic-NOAA changed the title fixed excessive evaporation when both innerloop=T and mraerosol=T Fixed excessive evaporation when both innerloop=T and mraerosol=T Apr 5, 2024
@grantfirl
Copy link
Collaborator

@AnningCheng-NOAA We'd like to combine this with a CCPP Framework commit hash update. I can walk you through this, or, if you add me as a collaborator with write permissions, I can do it for you and push to this branch. To add me as a collaborator, go to https://github.com/AnningCheng-NOAA/fv3atm/, click on Settings, then Collaborators. Click the "Add people" button and add the user 'grantfirl' as a collaborator.

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented Apr 19, 2024 via email

@grantfirl
Copy link
Collaborator

@grant Firl @.> just added you as a collaborator. Please let me know if it works.

On Fri, Apr 19, 2024 at 11:51 AM Grant Firl @.
> wrote: @AnningCheng-NOAA https://github.com/AnningCheng-NOAA We'd like to combine this with a CCPP Framework commit hash update. I can walk you through this, or, if you add me as a collaborator with write permissions, I can do it for you and push to this branch. To add me as a collaborator, go to https://github.com/AnningCheng-NOAA/fv3atm/, click on Settings, then Collaborators. Click the "Add people" button and add the user 'grantfirl' as a collaborator. — Reply to this email directly, view it on GitHub <#816 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALQPMIMWEZSUVMTTIDQXOGLY6E4PJAVCNFSM6AAAAABFSAX7USVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRWHA2DSMJWHE . You are receiving this because you were mentioned.Message ID: @.***>

Yes, it worked fine. Thanks.

@grantfirl
Copy link
Collaborator

This PR is also waiting on NCAR/ccpp-framework#556

@grantfirl
Copy link
Collaborator

Associated CCPP-framework PR is NCAR/ccpp-framework#555

@grantfirl
Copy link
Collaborator

@BrianCurtis-NOAA The commit hash and the branch name in .gitmodules is correct for CCPP-framework in the FV3atm PR.

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented Apr 30, 2024 via email

@grantfirl
Copy link
Collaborator

@zach1221 CCPP PRs have been merged and this is updated and ready to approve/merge.

@zach1221
Copy link
Collaborator

zach1221 commented May 1, 2024

ccpp-physics/frameworks PRs merged.

@zach1221 CCPP PRs have been merged and this is updated and ready to approve/merge.

Thanks, Grant! @jkbk2004 @BrianCurtis-NOAA this PR is ready for review

@jkbk2004 jkbk2004 merged commit 683061b into NOAA-EMC:develop May 1, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants