Combination for CCPP-physics #213 and #218 (H2O scheme refactor and C3/SAS/MYNN fix) #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture/refactor_h2ophys
…wales/fv3atm into feature/refactor_h2ophys
…ture/refactor_h2ophys
…wales/fv3atm into feature/refactor_h2ophys
|
@BrianCurtis-NOAA @DusanJovic-NOAA can you review this PR please? We're looking to potentially start testing 2408 next. |
DusanJovic-NOAA
approved these changes
Aug 27, 2024
BrianCurtis-NOAA
approved these changes
Aug 27, 2024
|
@jkbk2004 we should be ready to merge here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a combination PR for work from @dustinswales (#848) and @lisa-bengtsson (#853). Neither PR changes answers.
Description for #848
Included in this PR are changes to NRL's stratospheric h2o photochemistry scheme to make it "safe across multiple CCPP instances". These changes are identical to the reorganization that ufs-community/ccpp-physics#75.
Both schemes are called from a new module, GFS_photochemistry, at the start of the time-split section of the suite. Previously, the ozone scheme was called from GFS_stateout_update, and the h2o scheme was called just after.
Description for #853
Issue: ufs-community/ufs-weather-model#2342
When running physics suites using C3 or SAS convection with the prognostic area fraction closure, and MYNN PBL, there is a bug in that the convection expects the field "tendency_of_vertically_diffused_tracer_concentration", to compute the turbulent moisture flux component of the total moisture convergence term, that is output from all PBL schemes except MYNN.
This PR updates the submodule pointer to ccpp/physics which adds "tendency_of_vertically_diffused_tracer_concentration" as output from the MYNN PBL scheme
Addresses CCPP PR:
ufs-community/ccpp-physics#218
Issue(s) addressed
Testing
These changes were tested individually and as a combination using UFS RTs on Hera. All tests pass.
Dependencies
ufs-community/ccpp-physics#223