Tenth reconciliation PR from production/RRFS.v1 #926
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantfirl
commented
Feb 7, 2025
| @@ -187,8 +187,7 @@ subroutine history_type_register(hist, Diag, Time, Atm_block, Model, xlon, xlat, | |||
| hist%fhzero = Model%fhzero | |||
| ! hist%ncld = Model%ncld | |||
| hist%ncld = Model%imp_physics | |||
| hist%nsoil = Model%lsoil | |||
| hist%nsoil_lsm = Model%lsoil_lsm | |||
| hist%nsoil = Model%lsoil_lsm | |||
There was a problem hiding this comment.
@JiliDong-NOAA Please take a look here. I noticed that there was a difference between what exists in the develop branch and your PR into production/RRFS.v1 here: #869. I'm not sure that I handled this conflict correctly.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is @JiliDong-NOAA 's work and is identical to #869
This PR follows Jongil's suggestion and aims to reduce the large convective reflectivity caused by saSAS adjustment in the first timestep during a warm start. The issue is likely related to the inconsistency when DA updates the moisture at t but not the moisture from the previous timestep (t-36s). The moisture from the previous timestep is needed for initializing sigmab (updraft area fraction) when calculating qadv (q advection or tendency term).
The PR forces qadv to zero in the first timestep when a namelist parameter sigmab_coldstart is set to .true. It also reduces the lower limit of sigmab from 0.01 to 0.0 in the first timestep.
Two bug fixes for LSM soil output with inline post are added in this PR:
2.1 #877
2.2 @ericaligo-NOAA identified and fixed another bug with inline post when "lsoil" is different from "lsoil_lsm" which can happen when cold starting from Noah LSM input but running forecast with RUC LSM. In the above example, lsoil=4 and lsoil_lsm=9. There is no soil variables from inline post. The fix will set the correct "nsoil" based on lsoil_lsm and recover the LSM soil output.
Issue(s) addressed
None
Testing
UFS RTs on Hera
Changes baselines for tests using saSAS deep convection
Dependencies
ufs-community/ccpp-physics#252