Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire BASE_SVN/base_svn in develop #1035

Closed
KateFriedman-NOAA opened this issue Sep 27, 2022 · 2 comments · Fixed by #1036
Closed

Retire BASE_SVN/base_svn in develop #1035

KateFriedman-NOAA opened this issue Sep 27, 2022 · 2 comments · Fixed by #1036
Assignees
Labels
maintenance Regular updates and maintenance work

Comments

@KateFriedman-NOAA
Copy link
Member

Description

The BASE_SVN/base_svn variable and path are no longer needed. No longer use SVN since moving to Git. Now use BASE_GIT/base_git variable and path for local install locations. Retire any remaining references to BASE_SVN and base_svn from `develop.

Acceptance Criteria (Definition of Done)

References to and use of BASE_SVN and base_svn no longer exist in develop.

@KateFriedman-NOAA KateFriedman-NOAA added the maintenance Regular updates and maintenance work label Sep 27, 2022
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Sep 27, 2022
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Sep 27, 2022
@KateFriedman-NOAA
Copy link
Member Author

KateFriedman-NOAA commented Sep 27, 2022

Only remaining instances of BASE_SVN or base_svn are in the workflow hosts files:

-bash-4.2$ pwd
/scratch1/NCEPDEV/global/Kate.Friedman/git/fork_feature/retire-basesvn
-bash-4.2$ grep BASE_SVN * -r
-bash-4.2$ grep base_svn * -r                                                                                                                                              
workflow/hosts/orion.yaml:base_svn: '/work/noaa/global/glopara/svn'
workflow/hosts/hera.yaml:base_svn: '/scratch1/NCEPDEV/global/glopara/svn'

Removed instance of base_svn in incoming wcoss2.yaml hosts file.

KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Sep 27, 2022
@KateFriedman-NOAA
Copy link
Member Author

Removed remaining instances of base_svn from hosts files @ 5377ab3

-bash-4.2$ pwd
/scratch1/NCEPDEV/global/Kate.Friedman/git/fork_feature/retire-basesvn
-bash-4.2$ git branch
  develop
* feature/retire-basesvn
-bash-4.2$ grep BASE_SVN * -r
-bash-4.2$ grep base_svn * -r
-bash-4.2$ 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Regular updates and maintenance work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant