Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate Python resource structure #2783

Closed
DavidHuber-NOAA opened this issue Jul 22, 2024 · 0 comments · Fixed by #2839
Closed

Consolidate Python resource structure #2783

DavidHuber-NOAA opened this issue Jul 22, 2024 · 0 comments · Fixed by #2839
Assignees
@DavidHuber-NOAA
Labels
feature New feature or request

Comments

@DavidHuber-NOAA
Copy link
Contributor

What new functionality do you need?

PR #2727 introduced a simplified method to calculate resources for each job and machine. In doing so, it reworks the way resources are handled when running setup_xml.py such that the configuration dictionary is redefined for each required RUN. Rather than redefining the same dictionary each time, a single dictionary with subdictionaries for each RUN should be implemented. This will allow all configuration entries to be retained during execution.

What are the requirements for the new functionality?

Acceptance Criteria

No changes to resource calculations and CI tests run successfully on all platforms.

Suggest a solution (optional)

No response
@DavidHuber-NOAA DavidHuber-NOAA added feature New feature or request triage Issues that are triage labels Jul 22, 2024
@DavidHuber-NOAA DavidHuber-NOAA self-assigned this Jul 22, 2024
@DavidHuber-NOAA DavidHuber-NOAA removed the triage Issues that are triage label Jul 22, 2024
@DavidHuber-NOAA DavidHuber-NOAA mentioned this issue Jul 25, 2024
Merged
16 tasks
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this issue Aug 16, 2024
@DavidHuber-NOAA
Construct dict of dicts of config files NOAA-EMC#2783
08f558e
@DavidHuber-NOAA DavidHuber-NOAA mentioned this issue Aug 16, 2024
Merged
9 tasks
WalterKolczynski-NOAA pushed a commit that referenced this issue Sep 10, 2024
@DavidHuber-NOAA
Consolidate python configuration dictionaries (#2839)
b443915 
This modifies the way the `config` dictionary is constructed and
referenced. Rather than updating a single configuration dictionary with
each `RUN`, a `RUN`-based dictionary of `config` dictionaries is created
and referenced by the appropriate `RUN` when calculating resources.

This also makes the methods that were hidden before #2727 hidden again.

Resolves #2783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavidHuber-NOAA DavidHuber-NOAA

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consolidate python configuration dictionaries DavidHuber-NOAA/global-workflow
1 participant
@DavidHuber-NOAA