Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exglobal_forecast.sh unnecessary sCDATE in code #956

Closed
lgannoaa opened this issue Aug 3, 2022 · 2 comments · Fixed by #1133
Closed

exglobal_forecast.sh unnecessary sCDATE in code #956

lgannoaa opened this issue Aug 3, 2022 · 2 comments · Fixed by #1133

Comments

@lgannoaa
Copy link
Contributor

lgannoaa commented Aug 3, 2022

Description

https://github.com/NOAA-EMC/global-workflow/blob/feature/ops-wcoss2/scripts/exglobal_forecast.sh#L224-L238
Line 224 should be removed because sCDATE is set from the line 227 and 233.
@WalterKolczynski-NOAA
Copy link
Contributor

L252 of forecast_predet in develop.

This really isn't the kind of thing we need to worry about removing in the ops branch.

@lgannoaa
Copy link
Contributor Author

lgannoaa commented Aug 3, 2022

L252 of forecast_predet in develop.

This really isn't the kind of thing we need to worry about removing in the ops branch.

This issue is not about removing in the ops branch. We know an issue noted in the issue where it is designed for. Why not fix it?

@lgannoaa lgannoaa mentioned this issue Nov 22, 2022
Merged
3 tasks
WalterKolczynski-NOAA pushed a commit that referenced this issue Nov 22, 2022
@lgannoaa
Remove unnecessary sCDATE assignment in forecast_predet.sh (#1133)
9955a26 
`ush/forecast_predet.sh` contains an unnecessary sCDATE assignment. Therefore this line is safe to be removed.

Fixes #956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary sCDATE assignment in forecast_predet.sh lgannoaa/global-workflow
2 participants
@WalterKolczynski-NOAA @lgannoaa