Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make needed updates to run forecast from GEFS #1203
Make needed updates to run forecast from GEFS #1203
Changes from 20 commits
1b5827c
38f5dce
fe5e830
4812945
01f344b
9865bf9
46a87cb
3f03cdd
39c641e
9f57a1f
c905b74
fe82706
a49956c
d0924ab
af7dc51
052ad49
f0aaaf0
a56b707
61f44aa
4ef0d93
bf053c1
4346c8c
e1f8305
bfcd22f
ec701f5
4299561
43555a0
dd70d8d
fd325ac
33b4d90
c95d4a6
119e5b7
5c95d7a
eb9d39c
1be0572
7ee08e2
b686fe7
3d99c50
1ac2957
c6e082c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead, how about this on the line above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$CDUMP should be "gfs", not "GFS", should I change FHOUT_ENKF_GFS to FHOUT_ENKF_gfs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be consistent, I think using FHOUT_ENKF_GFS is better than FHOUT_ENKF_gfs, because we don't have FHOUT_ENKF_GDAS variable. So I think I don't need to change it.