Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create analysis files for early-cycle EnKF by default #1237

Merged
merged 6 commits into from
Jan 25, 2023
Merged

Create analysis files for early-cycle EnKF by default #1237

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
11b408c
changes to allow early cycle enkf to produce analysis files by default
Jan 10, 2023
9b93f37
Merge branch 'NOAA-EMC:develop' into feature/default_early_cycle_enkf…
TravisElless-NOAA Jan 11, 2023
60ce604
Merge branch 'NOAA-EMC:develop' into feature/default_early_cycle_enkf…
TravisElless-NOAA Jan 17, 2023
17c16c1
Update early cycle DO_CALC variable name
Jan 17, 2023
68fac32
Merge branch 'develop' into feature/default_early_cycle_enkf_create_a…
TravisElless-NOAA Jan 25, 2023
1bb192d
update_conflict_files_via_clone
TravisElless-NOAA Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions parm/config/config.base.emc.dyn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,9 @@ if [ $OUTPUT_FILE = "nemsio" ]; then
export DO_CALC_ANALYSIS="NO"
fi

# Write analysis files for early cycle EnKF
export DO_GFS_ENKF_CALC_INCREMENT="YES"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a picky comment.
Can we instead define this as DO_CALC_INCREMENT_ENKF_GFS.
Here are my reasons:

  1. The default is DO_CALC_INCREMENT
  2. If doing this for EnKF regardless of cycle, it could be extended to DO_CALC_INCREMENT_ENKF, similar to FHOUT_ENKF.
  3. If doing this for EnKF and only for the GFS, this could be extended to DO_CALC_INCREMENT_ENKF_GFS, similar to FHMAX_ENKF_GFS.

Other than that, the changes in this PR are fine.

Your thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to use DO_CALC_INCREMENT_ENKF_GFS to be consistent with other variables.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic makes sense. A commit changing this variable name will be forthcoming.


# Stratospheric increments to zero
export INCVARS_ZERO_STRAT="'sphum_inc','liq_wat_inc','icmr_inc'"
export INCVARS_EFOLD="5"
Expand Down
11 changes: 7 additions & 4 deletions scripts/exgdas_enkf_ecen.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ pwd=$(pwd)

# Base variables
CDATE=${CDATE:-"2010010100"}
CDUMP=${CDUMP:-"gdas"}
DONST=${DONST:-"NO"}
export CASE=${CASE:-384}
ntiles=${ntiles:-6}
Expand Down Expand Up @@ -60,8 +61,11 @@ FHMIN=${FHMIN_ECEN:-3}
FHMAX=${FHMAX_ECEN:-9}
FHOUT=${FHOUT_ECEN:-3}
FHSFC=${FHSFC_ECEN:-$FHMIN}
DO_CALC_INCREMENT=${DO_CALC_INCREMENT:-"NO"}

if [ $CDUMP = "gfs" ]; then
DO_CALC_INCREMENT=${DO_GFS_ENKF_CALC_INCREMENT:-"NO"}
else
DO_CALC_INCREMENT=${DO_CALC_INCREMENT:-"NO"}
fi

# global_chgres stuff
CHGRESNEMS=${CHGRESNEMS:-$HOMEgfs/exec/enkf_chgres_recenter.x}
Expand Down Expand Up @@ -328,8 +332,7 @@ if [ $DO_CALC_INCREMENT = "YES" ]; then
. prep_step

$NCP $CALCINCEXEC $DATA

rm calc_increment.nml
[[ -f calc_increment.nml ]] && rm calc_increment.nml
cat > calc_increment.nml << EOF
&setup
datapath = './'
Expand Down
9 changes: 7 additions & 2 deletions scripts/exgdas_enkf_update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ ENKFEXEC=${ENKFEXEC:-$HOMEgfs/exec/enkf.x}

# Cycling and forecast hour specific parameters
CDATE=${CDATE:-"2001010100"}
CDUMP=${CDUMP:-"gdas"}

# Filenames.
GPREFIX=${GPREFIX:-""}
Expand Down Expand Up @@ -84,7 +85,11 @@ cnvw_option=${cnvw_option:-".false."}
netcdf_diag=${netcdf_diag:-".true."}
modelspace_vloc=${modelspace_vloc:-".false."} # if true, 'vlocal_eig.dat' is needed
IAUFHRS_ENKF=${IAUFHRS_ENKF:-6}
DO_CALC_INCREMENT=${DO_CALC_INCREMENT:-"NO"}
if [ $CDUMP = "gfs" ]; then
DO_CALC_INCREMENT=${DO_GFS_ENKF_CALC_INCREMENT:-"NO"}
else
DO_CALC_INCREMENT=${DO_CALC_INCREMENT:-"NO"}
fi
INCREMENTS_TO_ZERO=${INCREMENTS_TO_ZERO:-"'NONE'"}

################################################################################
Expand All @@ -96,11 +101,11 @@ if [ $SUFFIX = ".nc" ]; then
use_gfs_ncio=".true."
use_gfs_nemsio=".false."
paranc=${paranc:-".true."}
WRITE_INCR_ZERO="incvars_to_zero= $INCREMENTS_TO_ZERO,"
aerorahul marked this conversation as resolved.
Show resolved Hide resolved
if [ $DO_CALC_INCREMENT = "YES" ]; then
write_fv3_incr=".false."
else
write_fv3_incr=".true."
WRITE_INCR_ZERO="incvars_to_zero= $INCREMENTS_TO_ZERO,"
fi
else
LEVS_ENKF=${LEVS_ENKF:-$($NEMSIOGET $ATMGES_ENSMEAN dimz | awk '{print $2}')}
Expand Down