-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nemsio support #1255
Remove nemsio support #1255
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,6 @@ pwd=$(pwd) | |
# Utilities | ||
NCP=${NCP:-"/bin/cp -p"} | ||
NLN=${NLN:-"/bin/ln -sf"} | ||
NEMSIOGET=${NEMSIOGET:-$NWPROD/utils/exec/nemsio_get} | ||
NCLEN=${NCLEN:-$HOMEgfs/ush/getncdimlen} | ||
USE_CFP=${USE_CFP:-"NO"} | ||
CFP_MP=${CFP_MP:-"NO"} | ||
|
@@ -89,30 +88,20 @@ INCREMENTS_TO_ZERO=${INCREMENTS_TO_ZERO:-"'NONE'"} | |
|
||
################################################################################ | ||
ATMGES_ENSMEAN=$COMIN_GES_ENS/${GPREFIX}atmf006.ensmean${GSUFFIX} | ||
if [ $SUFFIX = ".nc" ]; then | ||
LONB_ENKF=${LONB_ENKF:-$($NCLEN $ATMGES_ENSMEAN grid_xt)} # get LONB_ENKF | ||
LATB_ENKF=${LATB_ENKF:-$($NCLEN $ATMGES_ENSMEAN grid_yt)} # get LATB_ENFK | ||
LEVS_ENKF=${LEVS_ENKF:-$($NCLEN $ATMGES_ENSMEAN pfull)} # get LEVS_ENFK | ||
use_gfs_ncio=".true." | ||
use_gfs_nemsio=".false." | ||
paranc=${paranc:-".true."} | ||
if [ $DO_CALC_INCREMENT = "YES" ]; then | ||
write_fv3_incr=".false." | ||
else | ||
write_fv3_incr=".true." | ||
WRITE_INCR_ZERO="incvars_to_zero= $INCREMENTS_TO_ZERO," | ||
fi | ||
LONB_ENKF=${LONB_ENKF:-$($NCLEN $ATMGES_ENSMEAN grid_xt)} # get LONB_ENKF | ||
LATB_ENKF=${LATB_ENKF:-$($NCLEN $ATMGES_ENSMEAN grid_yt)} # get LATB_ENFK | ||
LEVS_ENKF=${LEVS_ENKF:-$($NCLEN $ATMGES_ENSMEAN pfull)} # get LEVS_ENFK | ||
use_gfs_ncio=".true." | ||
use_gfs_nemsio=".false." | ||
Comment on lines
+94
to
+95
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These should also be able to be removed now. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (1) The use_gfs_nemsio is part of the enkf.nml namelist. It should not be changed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is no need for these variables. So they could/should be removed. |
||
paranc=${paranc:-".true."} | ||
if [ $DO_CALC_INCREMENT = "YES" ]; then | ||
write_fv3_incr=".false." | ||
else | ||
LEVS_ENKF=${LEVS_ENKF:-$($NEMSIOGET $ATMGES_ENSMEAN dimz | awk '{print $2}')} | ||
LATB_ENKF=${LATB_ENKF:-$($NEMSIOGET $ATMGES_ENSMEAN dimy | awk '{print $2}')} | ||
LONB_ENKF=${LONB_ENKF:-$($NEMSIOGET $ATMGES_ENSMEAN dimx | awk '{print $2}')} | ||
use_gfs_ncio=".false." | ||
use_gfs_nemsio=".true." | ||
paranc=${paranc:-".false."} | ||
write_fv3_incr=".true." | ||
WRITE_INCR_ZERO="incvars_to_zero= $INCREMENTS_TO_ZERO," | ||
fi | ||
LATA_ENKF=${LATA_ENKF:-$LATB_ENKF} | ||
LONA_ENKF=${LONA_ENKF:-$LONB_ENKF} | ||
|
||
SATANGL=${SATANGL:-${FIXgsi}/global_satangbias.txt} | ||
SATINFO=${SATINFO:-${FIXgsi}/global_satinfo.txt} | ||
CONVINFO=${CONVINFO:-${FIXgsi}/global_convinfo.txt} | ||
|
@@ -121,7 +110,6 @@ SCANINFO=${SCANINFO:-${FIXgsi}/global_scaninfo.txt} | |
HYBENSINFO=${HYBENSINFO:-${FIXgsi}/global_hybens_info.l${LEVS_ENKF}.txt} | ||
ANAVINFO=${ANAVINFO:-${FIXgsi}/global_anavinfo.l${LEVS_ENKF}.txt} | ||
VLOCALEIG=${VLOCALEIG:-${FIXgsi}/vlocal_eig_l${LEVS_ENKF}.dat} | ||
|
||
ENKF_SUFFIX="s" | ||
[[ $SMOOTH_ENKF = "NO" ]] && ENKF_SUFFIX="" | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,38 +36,20 @@ export INCREMENT=12 | |
export MAKEBUFR=NO | ||
export F00FLAG=YES | ||
export fformat=${OUTPUT_FILE:-netcdf} | ||
if [ $fformat == "netcdf" ] | ||
then | ||
export atmfm="nc" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one too, I think. |
||
export logfm="txt" | ||
else | ||
export atmfm="nemsio" | ||
export logfm="nemsio" | ||
fi | ||
|
||
export NINT1=${FHOUT_HF_GFS:-1} | ||
export NEND1=${FHMAX_HF_GFS:-120} | ||
export NINT3=${FHOUT_GFS:-3} | ||
export NINT1=${FHOUT_HF_GFS:-1} | ||
export NEND1=${FHMAX_HF_GFS:-120} | ||
export NINT3=${FHOUT_GFS:-3} | ||
|
||
rm -f -r ${COMOUT}/bufr.${cycle} | ||
mkdir -p ${COMOUT}/bufr.${cycle} | ||
|
||
if [ -f $HOMEgfs/ush/getncdimlen ] | ||
then | ||
GETDIM=$HOMEgfs/ush/getncdimlen | ||
else | ||
GETDIM=$EXECbufrsnd/getncdimlen | ||
fi | ||
if [ $fformat == "netcdf" ] | ||
then | ||
export LEVS=$($GETDIM $COMIN/${RUN}.${cycle}.atmf000.${atmfm} pfull) | ||
if [ -f $HOMEgfs/ush/getncdimlen ]; then | ||
GETDIM=$HOMEgfs/ush/getncdimlen | ||
else | ||
# Extract number of vertical levels from $STARTHOUR atmospheric file | ||
export NEMSIOGET=${NEMSIOGET:-$EXECbufrsnd/nemsio_get} | ||
fhr3=$(printf %03i $STARTHOUR) | ||
ATMFCS=$COMIN/${RUN}.${cycle}.atmf${fhr3}.nemsio | ||
export LEVS=$($NEMSIOGET $ATMFCS dimz | awk '{print $2}') | ||
GETDIM=$EXECbufrsnd/getncdimlen | ||
fi | ||
export LEVS=$($GETDIM $COMIN/${RUN}.${cycle}.atmf000.${atmfm} pfull) | ||
|
||
### Loop for the hour and wait for the sigma and surface flux file: | ||
export FSTART=$STARTHOUR | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,12 +16,7 @@ fi | |
# CURRENT CYCLE | ||
APREFIX="${CDUMP}.t${cyc}z." | ||
ASUFFIX=${ASUFFIX:-${SUFFIX}} | ||
|
||
if [ "${ASUFFIX}" = ".nc" ]; then | ||
format="netcdf" | ||
else | ||
format="nemsio" | ||
fi | ||
format="netcdf" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Variable format is used locally. Therefore it should be ok not to change it. |
||
|
||
# Realtime parallels run GFS MOS on 1 day delay | ||
# If realtime parallel, back up CDATE_MOS one day | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -501,14 +501,8 @@ EOF | |
JCAP_STP=${JCAP_STP:-$JCAP_CASE} | ||
LONB_STP=${LONB_STP:-$LONB_CASE} | ||
LATB_STP=${LATB_STP:-$LATB_CASE} | ||
|
||
cd $DATA | ||
|
||
affix="nc" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Variable affix is used locally. Therefore, no need to modify. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The point is I want you to replace There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since there is not other |
||
if [ "$OUTPUT_FILE" = "nemsio" ]; then | ||
affix="nemsio" | ||
fi | ||
|
||
if [ $QUILTING = ".true." -a $OUTPUT_GRID = "gaussian_grid" ]; then | ||
fhr=$FHMIN | ||
for fhr in $OUTPUT_FH; do | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -133,11 +133,10 @@ FV3_GFS_predet(){ | |
|
||
QUILTING=${QUILTING:-".true."} | ||
OUTPUT_GRID=${OUTPUT_GRID:-"gaussian_grid"} | ||
OUTPUT_FILE=${OUTPUT_FILE:-"nemsio"} | ||
OUTPUT_FILE=${OUTPUT_FILE:-"netcdf"} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And this. |
||
WRITE_NEMSIOFLIP=${WRITE_NEMSIOFLIP:-".true."} | ||
WRITE_FSYNCFLAG=${WRITE_FSYNCFLAG:-".true."} | ||
affix="nemsio" | ||
[[ "$OUTPUT_FILE" = "netcdf" ]] && affix="nc" | ||
affix="nc" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And this. |
||
|
||
rCDUMP=${rCDUMP:-$CDUMP} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -121,13 +121,8 @@ LATB_SFC=${LATB_SFC:-$LATB_CASE} | |
DONST=${DONST:-"NO"} | ||
LEVS=${LEVS:-64} | ||
LEVSP1=$(($LEVS+1)) | ||
OUTPUT_FILE=${OUTPUT_FILE:-"nemsio"} | ||
if [ $OUTPUT_FILE = "netcdf" ]; then | ||
export NETCDF_OUT=".true." | ||
else | ||
export NETCDF_OUT=".false." | ||
fi | ||
|
||
OUTPUT_FILE=${OUTPUT_FILE:-"netcdf"} | ||
export NETCDF_OUT=".true." | ||
Comment on lines
+124
to
+125
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And these. |
||
# Directories. | ||
gfs_ver=${gfs_ver:-v16.3.0} | ||
BASEDIR=${BASEDIR:-${PACKAGEROOT:-/lfs/h1/ops/prod/packages}} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -222,8 +222,7 @@ export LOGSCRIPT=${LOGSCRIPT:-} | |
export ENDSCRIPT=${ENDSCRIPT:-} | ||
export GFSOUT=${GFSOUT:-gfsout} | ||
export CTLFILE=${CTLFILE:-${NWPROD}/parm/gfs_cntrl.parm} | ||
#export MODEL_OUT_FORM=${MODEL_OUT_FORM:-binarynemsiompiio} | ||
export OUTPUT_FILE=${OUTPUT_FILE:-"nemsio"} | ||
export OUTPUT_FILE=${OUTPUT_FILE:-"netcdf"} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And this. |
||
export GRIBVERSION=${GRIBVERSION:-'grib1'} | ||
# Other variables. | ||
export POSTGPVARS=${POSTGPVARS} | ||
|
@@ -260,16 +259,10 @@ fi | |
export SIGHDR=${SIGHDR:-${NWPROD}/exec/global_sighdr} | ||
export IDRT=${IDRT:-4} | ||
|
||
# run post to read nemsio file if OUTTYP=4 | ||
# run post to read file if OUTTYP=4 | ||
if (( OUTTYP == 4 )) ; then | ||
if [ "${OUTPUT_FILE}" = "netcdf" ]; then | ||
export MODEL_OUT_FORM=${MODEL_OUT_FORM:-netcdfpara} | ||
elif [ "${OUTPUT_FILE}" = "nemsio" ]; then | ||
export MODEL_OUT_FORM=${MODEL_OUT_FORM:-binarynemsiompiio} | ||
else | ||
export MODEL_OUT_FORM=${MODEL_OUT_FORM:-binarynemsiompiio} | ||
fi | ||
export GFSOUT=${NEMSINP} | ||
export MODEL_OUT_FORM=${MODEL_OUT_FORM:-netcdfpara} | ||
export GFSOUT=${NEMSINP} | ||
fi | ||
|
||
# allow threads to use threading in Jim's sp lib | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be able to get rid of these variables entirely now. Find wherever they are used and replace with hard-coded values.