GEFS Staging in exglobal_stage_ic #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
shellcheck found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
AnilKumar-NOAA
force-pushed
the
upstream/develop
branch
from
1c2b483 to
3fdd4a8
Compare
|
Please fill in the PR template. |
WalterKolczynski-NOAA
requested changes
Sep 27, 2023
|
Automated global-workflow Testing Results: |
emcbot
added
CI-Hera-Passed
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
AnilKumar-NOAA
force-pushed
the
upstream/develop
branch
from
a271675 to
ae3db53
Compare
WalterKolczynski-NOAA
force-pushed
the
upstream/develop
branch
from
ae3db53 to
a271675
Compare
aerorahul
reviewed
Oct 27, 2023
scripts/exglobal_stage_ic.sh
Outdated
| rc=$? | ||
| (( rc != 0 )) && error_message "${source}" "${target}" "${rc}" | ||
| [[ ${rc} -ne 0 ]] && error_message "${src}" "${tgt}" "${rc}" |
There was a problem hiding this comment.
why [[ ${rc} -ne 0 ]] here?
Elsewhere we have (( rc != 0 ))
aerorahul
reviewed
Oct 27, 2023
parm/config/gefs/config.waveinit
Outdated
| @@ -0,0 +1,14 @@ | |||
| #! /usr/bin/env bash | |||
There was a problem hiding this comment.
Why is this being added? Are we running with waves in GEFS at this point?
There was a problem hiding this comment.
we just copy that files from gfs when we were trying to run with wave.
aerorahul
reviewed
Oct 27, 2023
aerorahul
approved these changes
Oct 27, 2023
aerorahul
reviewed
Oct 27, 2023
Not sure whey Rocoto is not finding this link to this |
|
Automated global-workflow Testing Results: |
emcbot
added
CI-Orion-Failed
|
Automated global-workflow Testing Results: |
|
@aerorahul @WalterKolczynski-NOAA - @jiandewang just pointed out that the IC folders have been moved from the ufscpara and his space on wcoss2. We specifically moved it out of the glopara space on wcoss2 because of our data needs exceeding the space requirements on WCOSS2. Is this intentional? Did you just need us to refactor the space? We'd be happy to work with you on this. We will soon be adding ICs for HR3 and will need to know what the process for this is now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusts source paths for forecast-only ICs in support of extension to ensembles. New paths omit the resolution (that is captured by the IC id name) and allow for a member level.
Directories with the reorganized ICs have been added to the three tier-1 machines under glopara space.
Building on this, also adds capability to stage GEFS ICs.
Resolves #911
Type of change
Change characteristics
How has this been tested?
Checklist