Removes jlogfile and postmsg instances from workflow

[HenryRWinterbottom]

Description

This PR addresses issue #2125. The following is accomplished:

• All remaining instances of jlogfile and postmsg have been removed from workflow scripts.

  Resolves Remove remaining jlogfile references #2125

Type of change

• Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

• Is this a breaking change (a change in existing functionality)? NO
• Does this change require a documentation update? NO

How has this been tested?

Tested on RDHPCS Hera. The following is a snapshot of the Rocoto status:

CYCLE                    TASK                       JOBID               STATE         EXIT STATUS     TRIES      DURATION
================================================================================================================================
202112201800                gdasfcst                    55647553           SUCCEEDED                   0         1         444.0
202112201800    gdasatmprod_f000-f003                    55646672           SUCCEEDED                   0         1          83.0
202112201800    gdasatmprod_f006-f009                    55646673           SUCCEEDED                   0         1          84.0
202112201800                gdasarch                    55646733           SUCCEEDED                   0         1          11.0
================================================================================================================================
202112210000                gdasprep                    55646734           SUCCEEDED                   0         1         216.0
202112210000                gdasanal                    55648363           SUCCEEDED                   0         1        1223.0
202112210000              gdassfcanl                    55649157                DEAD                   2         2          12.0
202112210000            gdasanalcalc                           -                   -                   -         -             -
202112210000            gdasanaldiag                    55647451           SUCCEEDED                   0         1          88.0
202112210000           gdasatmanlupp                    55646674           SUCCEEDED                   0         1          19.0
202112210000          gdasatmanlprod                    55646675           SUCCEEDED                   0         1          40.0
202112210000                gdasfcst                           -                   -                   -         -             -
202112210000    gdasatmprod_f000-f003                    55646676           SUCCEEDED                   0         1          82.0
202112210000    gdasatmprod_f006-f009                    55646677           SUCCEEDED                   0         1          83.0
202112210000             gdasfit2obs                    55646737           SUCCEEDED                   0         1           8.0
202112210000             gdasverfozn                    55647517           SUCCEEDED                   0         1          17.0
202112210000             gdasverfrad                    55647518           SUCCEEDED                   0         1         466.0
202112210000             gdasvminmon                    55647452           SUCCEEDED                   0         1           9.0
202112210000                gdasarch                    55647723           SUCCEEDED                   0         1          11.0
202112210000             gdascleanup                    55647760           SUCCEEDED                   0         1          10.0
202112210000                 gfsprep                    55646740           SUCCEEDED                   0         1         199.0
202112210000                 gfsanal                    55648364           SUCCEEDED                   0         1         824.0
202112210000               gfssfcanl                    55648794                DEAD                   2         2          12.0
202112210000             gfsanalcalc                           -                   -                   -         -             -
202112210000            gfsatmanlupp                    55646678           SUCCEEDED                   0         1          18.0
202112210000           gfsatmanlprod                    55646679           SUCCEEDED                   0         1          62.0
202112210000                 gfsfcst                           -                   -                   -         -             -
202112210000    gfsatmprod_f000-f012                    55646680           SUCCEEDED                   0         1         192.0
202112210000              gfsvminmon                    55647211           SUCCEEDED                   0         1           9.0
202112210000                 gfsarch                    55647266           SUCCEEDED                   0         1          19.0
202112210000              gfscleanup                    55647268           SUCCEEDED                   0         1           9.0
================================================================================================================================
202112210600                gdasprep                    55646745           SUCCEEDED                   0         1         184.0
202112210600                gdasanal                    55648365           SUCCEEDED                   0         1        1442.0
202112210600              gdassfcanl                    55649262                DEAD                   2         2          13.0
202112210600            gdasanalcalc                           -                   -                   -         -             -
202112210600            gdasanaldiag                    55647520           SUCCEEDED                   0         1          76.0
202112210600           gdasatmanlupp                    55646681           SUCCEEDED                   0         1          20.0
202112210600          gdasatmanlprod                    55646682           SUCCEEDED                   0         1          41.0
202112210600                gdasfcst                           -                   -                   -         -             -
202112210600    gdasatmprod_f000-f003                    55646683           SUCCEEDED                   0         1          83.0
202112210600    gdasatmprod_f006-f009                    55646684           SUCCEEDED                   0         1          84.0
202112210600             gdasfit2obs                    55646746           SUCCEEDED                   0         1           9.0
202112210600             gdasverfozn                    55647554           SUCCEEDED                   0         1          16.0
202112210600             gdasverfrad                    55647555           SUCCEEDED                   0         1         488.0
202112210600             gdasvminmon                    55647521           SUCCEEDED                   0         1           9.0
202112210600                gdasarch                    55647762           SUCCEEDED                   0         1          11.0
202112210600             gdascleanup                    55647783           SUCCEEDED                   0         1           9.0

Note, the gdassfcanl and gfssfcanl failures are not related to the modifications introduced in this PR.

Checklist

• Any dependent changes have been merged and published
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• New and existing tests pass with my changes
• I have made corresponding changes to the documentation if necessary

[KateFriedman-NOAA]

Cleanup of jlogfile references and related postmsg references look good for the most part. Left a few comments to address. Also, the following still need to be removed:

ush/radmon_verf_bcoef.sh:pgmout=${pgmout:-${jlogfile}}
ush/radmon_verf_bcor.sh:pgmout=${pgmout:-${jlogfile}}
ush/radmon_verf_angle.sh:export pgmout=${pgmout:-${jlogfile}}

[HenryRWinterbottom]

radmon_verf_bcor.sh

@KateFriedman-NOAA I wasn't sure how to handle this. Looking at scripts/exgdas_atmos_verfrad.sh and the jobs script jobs/JGDAS_ATMOS_VERFRAD, I don't see where pgmout is defined. What do you suggest?

[KateFriedman-NOAA]

@KateFriedman-NOAA I wasn't sure how to handle this. Looking at scripts/exgdas_atmos_verfrad.sh and the jobs script jobs/JGDAS_ATMOS_VERFRAD, I don't see where pgmout is defined. What do you suggest?

Take a look at a log for a verfrad job (e.g. gdasverfrad.log), search for where pgmout is set, and if it's set before entering those ush/radmon_*.sh scripts then I think it's safe to remove the pgmout=${pgmout:-${jlogfile}} lines in those three scripts.

Since you'll be touching some of the GSI monitor scripts I suggest adding @EdwardSafford-NOAA (GSI monitor POC) as an additional reviewer. He can let you know if that line removal is kosher.

[HenryRWinterbottom]

@KateFriedman-NOAA I wasn't sure how to handle this. Looking at scripts/exgdas_atmos_verfrad.sh and the jobs script jobs/JGDAS_ATMOS_VERFRAD, I don't see where pgmout is defined. What do you suggest?

Take a look at a log for a verfrad job (e.g. gdasverfrad.log), search for where pgmout is set, and if it's set before entering those ush/radmon_*.sh scripts then I think it's safe to remove the pgmout=${pgmout:-${jlogfile}} lines in those three scripts.

Since you'll be touching some of the GSI monitor scripts I suggest adding @EdwardSafford-NOAA (GSI monitor POC) as an additional reviewer. He can let you know if that line removal is kosher.

@EdwardSafford-NOAA I added you, as suggested by @KateFriedman-NOAA, to verify whether the above is a safe assumption. Thank you in advance.

[KateFriedman-NOAA]

Changes look good! Approve pending successful CI tests. Thanks @HenryWinterbottom-NOAA !

[EdwardSafford-NOAA]

Looks good to me. Thanks.