Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fx path for exglobal_prep_ocean_obs.py in JGLOBAL_PREP_OCEAN_OBS #2356

Closed
wants to merge 9 commits into from
Closed

Fx path for exglobal_prep_ocean_obs.py in JGLOBAL_PREP_OCEAN_OBS #2356

wants to merge 9 commits into from

Conversation

ShastriPaturi
Copy link

This PR fixes path for exglobal_prep_ocean_obs.py in jobs/JGLOBAL_PREP_OCEAN_OBS

Fixes #2353

@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title fix path for exglobal_prep_ocean_obs.py in jobs/JGLOBAL_PREP_OCEAN_OBS Fx path for exglobal_prep_ocean_obs.py in JGLOBAL_PREP_OCEAN_OBS Feb 28, 2024
aerorahul
aerorahul reviewed Mar 1, 2024
View reviewed changes
jobs/JGLOBAL_PREP_OCEAN_OBS Outdated
@@ -20,7 +20,7 @@ export PYTHONPATH=${HOMEgfs}/sorc/gdas.cd/ush:${PYTHONPATH}
###############################################################
# Run relevant script

EXSCRIPT=${GDASPREPOCNOBSPY:-${HOMEgfs}/ush/exglobal_prep_ocean_obs.py}
EXSCRIPT=${GDASPREPOCNOBSPY:-${HOMEgfs}/scripts/exglobal_prep_ocean_obs.py}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this script is available as it is being linked in ush. See here

aerorahul
aerorahul requested changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link_workflow.sh also needs to be updated for this change to take effect.

aerorahul
aerorahul reviewed Mar 7, 2024
View reviewed changes
parm/config/gfs/config.prepoceanobs
@@ -15,6 +15,10 @@ export OBS_YAML=${OBS_LIST}
# ocean analysis needs own dmpdir until standard dmpdir has full ocean obs
export DMPDIR=@DMPDIR@

# For BUFR2IODA json and python scripts
export JSON_TMPL_DIR=${HOMEgfs}/sorc/gdas.cd/parm/ioda/bufr2ioda
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export JSON_TMPL_DIR=${HOMEgfs}/sorc/gdas.cd/parm/ioda/bufr2ioda
export JSON_TMPL_DIR=${HOMEgfs}/parm/gdas/ioda/bufr2ioda

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aerorahul Trying to address this before opening the new PR - is the idea to link the yaml files from ${HOMEgfs}/sorc/gdas.cd/parm/ioda/bufr2ioda to ${HOMEgfs}/parm/gdas/ioda/bufr2ioda?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
All files from sorc/gdas.cd should be linked in the appropriate location in HOMEgfs/. The scripts, yamls, etc. should reference them using EXECgfs or PARMgfs or SCRgfs or USHgfs instead of HOMEgfs/sorc/gdas.cd/+parm or scripts or ush.

aerorahul
aerorahul requested changes Mar 7, 2024
View reviewed changes
parm/config/gfs/config.prepoceanobs
# For BUFR2IODA json and python scripts
export JSON_TMPL_DIR=${HOMEgfs}/sorc/gdas.cd/parm/ioda/bufr2ioda
export BUFR2IODA_PY_DIR=${HOMEgfs}/sorc/gdas.cd/ush/ioda/bufr2ioda
export KEEPDATA='YES'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is for debugging, then it should be removed from the PR.

@aerorahul
Copy link
Contributor

@ShastriPaturi
Can you please address the comments and update your branch with develop.

@aerorahul
Copy link
Contributor

@guillaumevernieres
Will someone pick up the work in this PR and address the review?

@guillaumevernieres
Copy link
Contributor

@guillaumevernieres Will someone pick up the work in this PR and address the review?

Yes @aerorahul . Sorry for the delay, @AndrewEichmann-NOAA will take over.

@AndrewEichmann-NOAA
Copy link
Contributor

@aerorahul @guillaumevernieres On it

@AndrewEichmann-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA Is there a way to have the PR point to a different fork/branch? I maneuvered this branch into my repository.

@aerorahul
Copy link
Contributor

@WalterKolczynski-NOAA Is there a way to have the PR point to a different fork/branch? I maneuvered this branch into my repository.

@AndrewEichmann-NOAA
I don't think we can change the originating branch once the PR is opened. We will have to close this and open a new PR from the new origin (your fork).
If it is ok with you, feel free to close this PR and leave a comment that this work will be in the PR you open or let us know and we can link the two.

@AndrewEichmann-NOAA AndrewEichmann-NOAA mentioned this pull request Apr 4, 2024
Merged
7 tasks
@AndrewEichmann-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA @aerorahul @guillaumevernieres This PR has been replaced by #2459 and should be closed

@guillaumevernieres
Copy link
Contributor

Closing this since it was reopened as a different PR (#2459) by @AndrewEichmann-NOAA

aerorahul pushed a commit that referenced this pull request Apr 12, 2024
@AndrewEichmann-NOAA
Fix paths in prepocnobs task (#2459)
80e4684 
This PR fixes path for exglobal_prep_ocean_obs.py in
jobs/JGLOBAL_PREP_OCEAN_OBS and associated config file

Fixes #2353, replaces
PR #2356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul requested changes

@AndrewEichmann-NOAA AndrewEichmann-NOAA AndrewEichmann-NOAA left review comments

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix path for exglobal_prep_ocean_obs.py in JJOB
5 participants
@ShastriPaturi @aerorahul @guillaumevernieres @AndrewEichmann-NOAA @WalterKolczynski-NOAA